IndexError: pop index out of range when instanciating Topology with a list of GeoDataFrame

[aspyk]

Hi !
I just get an IndexError: pop index out of range when trying to create a Topology like this:

groups = [list(i) for i in zip(*gdf.groupby("datetime"))]
tp.Topology(data=groups[1], object_name=groups[0])

It works fine with two objects in the list (as in this test) but it seems to break for longer list. The issue comes from here:

for ix in range(1, len(geom)):
    geom[0].update(geom.pop(ix))
data = geom[0]

It breaks because pop reduce the length of the list and so the last indices cannot be reached. Simply using geom[ix] instead of geom.pop(ix) should fix it. I'm going to test it.

[mattijn]

Thanks for raising the issue. If you can submit a PR if you have a fix for it, that would be great.
Otherwise a simple example how I can reproduce this error would be fine too!
Thanks again for reaching out!

[aspyk]

Ok thank you for your quick answer ! I've tried the fix locally and it seems to work, so I'm going to try to modify the unit test (ie using simply a list with more than two elements) and then submit a PR :)

[aspyk]

PR done, don't hesitate if something need to be changed :)

[mattijn]

Great @aspyk! You are almost there!
You've created a fork and made the changes.
If it is right there should now appear a green button on the github page of your forked repo of topojson stating, "compare & pull request".
If you click that button and add a title plus description in the new screen and then click "create pull request", it is official.

[aspyk]

Hum I thought I already did that... Is this not working ? #204

[mattijn]

Yes, now I see it. Maybe I hadn't refreshed the page.. thanks for the PR! Will check from there

[aspyk]

I see there is a problem on the CI, do you know what it is ?

[mattijn]

Probably a mistake on my side.. I hope to check somewhere this week

[aspyk]

ok, let me know if I can help on my side !

[mattijn]

fixed by #204