-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IndexError: pop index out of range when instanciating Topology with a list of GeoDataFrame #203
Comments
Thanks for raising the issue. If you can submit a PR if you have a fix for it, that would be great. |
Ok thank you for your quick answer ! I've tried the fix locally and it seems to work, so I'm going to try to modify the unit test (ie using simply a list with more than two elements) and then submit a PR :) |
PR done, don't hesitate if something need to be changed :) |
Great @aspyk! You are almost there! |
Hum I thought I already did that... Is this not working ? #204 |
Yes, now I see it. Maybe I hadn't refreshed the page.. thanks for the PR! Will check from there |
I see there is a problem on the CI, do you know what it is ? |
Probably a mistake on my side.. I hope to check somewhere this week |
ok, let me know if I can help on my side ! |
fixed by #204 |
Hi !
I just get an
IndexError: pop index out of range
when trying to create a Topology like this:It works fine with two objects in the list (as in this test) but it seems to break for longer list. The issue comes from here:
It breaks because pop reduce the length of the list and so the last indices cannot be reached. Simply using
geom[ix]
instead ofgeom.pop(ix)
should fix it. I'm going to test it.The text was updated successfully, but these errors were encountered: