Fix: topology for data without junctions and shared_coords=False, prequantize=False gives error

tests/test_topology.py

@@ -1,9 +1,12 @@
 import os
 import json
-from shapely import geometry, wkt
-import geopandas
-import geojson
+import pytest
+
 import fiona
+import geojson
+import geopandas
+from shapely import geometry, wkt
+
 import topojson
 
 
@@ -633,3 +636,28 @@ def test_topology_write_multiple_object_json_dict():
     topo_dict = topo.to_dict()
 
     assert len(topo_dict["objects"]) == 2
+
+
+@pytest.mark.parametrize(
+    "shared_coords, prequantize", 
+    [(True, True), (True, False), (False, True), (False, False)]
+)
+def test_topology_polygon_filled_island_no_junctions(shared_coords, prequantize):
+    data = geopandas.GeoDataFrame(
+        {
+            "name": ["abcde_fghij", "jihgf"],
+            "geometry": [
+                geometry.Polygon(
+                    shell=[[0, 0], [3, 0], [3, 3], [0, 3], [0, 0]], 
+                    holes=[[[1, 1], [1, 2], [2, 2], [2, 1], [1, 1]]],
+                ),
+                geometry.Polygon([[1, 1], [2, 1], [2, 2], [1, 2], [1, 1]]),
+            ]
+        }
+    )
+    topo = topojson.Topology(data, prequantize=prequantize, shared_coords=shared_coords)
+    topo_gdf = topo.to_gdf()
+
+    assert len(topo.output["arcs"]) == 2
+    assert topo_gdf.geometry[0] == data["geometry"][0]
+    assert topo_gdf.geometry[1] == data["geometry"][1]

topojson/core/cut.py

@@ -149,12 +149,12 @@ def _cutter(self, data):
             bk_array = np.expand_dims(
                 bk_array[~np.isnan(bk_array)].astype(np.int64), axis=1
             )
-            self._segments_list = data["linestrings"]
+            self._segments_list = [np.array(ls.coords) for ls in data["linestrings"]]
             self._duplicates = find_duplicates(data["linestrings"], type="linestring")
             self._bookkeeping_linestrings = bk_array
 
         else:
-            self._segments_list = data["linestrings"]
+            self._segments_list = [np.array(ls.coords) for ls in data["linestrings"]]
 
         # prepare to return object
         data["linestrings"] = self._segments_list

topojson/core/dedup.py

@@ -67,9 +67,6 @@ def _deduper(self, data):
 
         # deduplicate equal geometries
         # create numpy array from bookkeeping_geoms variable for numerical computation
-        if not self.options.topology and data["linestrings"]:
-            data["linestrings"] = [np.array(d.coords) for d in data["linestrings"]]
-
         if len(data["bookkeeping_linestrings"]):
             array_bk = np.vstack(data["bookkeeping_linestrings"])
         else: