Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drag and drop an event on the same day #487

Closed
cosf87 opened this issue Mar 27, 2018 · 1 comment · Fixed by #589
Closed

Drag and drop an event on the same day #487

cosf87 opened this issue Mar 27, 2018 · 1 comment · Fixed by #589
Labels
bug has PR

Comments

@cosf87
Copy link

cosf87 commented Mar 27, 2018

I'm submitting a ...

[x] Bug report
[ ] Feature request
[ ] Support request => Please do not submit a support request here, please ask on https://stackoverflow.com/

Bug description / Feature request

Calendar month view
If you drag an event and drop it on the same day, day click event is fired after drop event.
It works fine when you drag and drop an event from one day to another day, because only drop event is fired.

Versions

Angular: 5.2.9

Calendar library: 0.23.7

Browser name and version: Google Chrome 65.0.3325.181
@mattlewis92
Copy link
Owner

Ah I can reproduce, will try and find a fix, thanks! 😄

mattlewis92 added a commit that referenced this issue Jun 18, 2018
@mattlewis92
fix(month-view): prevent day clicked from firing when dragging events
c505d38 
BREAKING CHANGE:

Custom template users will now need to add a "dragActiveClass='cal-drag-active'" anywhere they use an mwlDraggable directive

If using the mwlDraggable directive anywhere else in your app you will need to apply `pointer-events: none` to the element yourself when it's being dragged. This can be done with the `dragActiveClass` option

Fixes #487
@mattlewis92 mattlewis92 mentioned this issue Jul 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug has PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

0.26 mattlewis92/angular-calendar
2 participants
@mattlewis92 @cosf87