Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove OnPush change detection #94

Closed
mattlewis92 opened this issue Nov 29, 2016 · 0 comments
Closed

Remove OnPush change detection #94

mattlewis92 opened this issue Nov 29, 2016 · 0 comments
Milestone
0.5.x

Comments

@mattlewis92
Copy link
Owner

It's better to leave it up to the user to implement this themselves by turning it off in the parent component that references the calendar components.
@mattlewis92 mattlewis92 added this to the 0.5.x milestone Nov 29, 2016
mattlewis92 pushed a commit that referenced this issue Dec 12, 2016
feat: remove change detection strategy from all components
e0dd7c8 
BREAKING CHANGE:

For enhanced performance it is recommended that you add `changeDetection: ChangeDetectionStrategy.OnPush` on all components that use this library. This will restrict change detection to only run when the components inputs change

Closes #94
@mattlewis92 mattlewis92 mentioned this issue Dec 12, 2016
Merged
mattlewis92 added a commit that referenced this issue Dec 18, 2016
@mattlewis92
feat: remove change detection strategy from all components (#101)
36458ab 
BREAKING CHANGE:

For enhanced performance it is recommended that you add `changeDetection: ChangeDetectionStrategy.OnPush` on all components that use this library. This will restrict change detection to only run when the components inputs change

Closes #94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.x
Development

No branches or pull requests
1 participant
@mattlewis92