Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support date-fns v2.0.0 beta #963

Closed
rosostolato opened this issue Apr 30, 2019 · 2 comments
Closed

Support date-fns v2.0.0 beta #963

rosostolato opened this issue Apr 30, 2019 · 2 comments

Comments

@rosostolato
Copy link

Is your feature request related to a problem? Please describe
Version 2 of date-fns breaks angular-calendar code

Describe the solution you'd like
Change date-fns adapater codes to support new version

Describe your use case for implementing this feature
I wish to use newer version of date-fns because it brings me more functions and I cannot have two libraries of date-fns in my project, it will make the final bundle larger.

@matts-bot
Copy link

matts-bot bot commented Apr 30, 2019

Thanks so much for opening an issue! If you'd like me to give priority to answering your issue or would just like to support this project, then please consider supporting me on Patreon

@mattlewis92
Copy link
Owner

mattlewis92 commented May 4, 2019

While date-fns is in alpha I don't want to support it officially as they could introduce breaking changes to the api which would mean having to makes changes here. As soon as date-fns v2 is stable I'll update the calendar to support it. In the meantime you could write your own date adapter which uses v2, the only thing that needs to change is the max function changed: https://stackblitz.com/edit/angular-xzssvt?file=demo/date-fns-v2-adapter.ts There's no direct dependency by this library on date-fns anymore so it won't appear in your node_modules and you won't get any warnings when using v2 of date-fns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants