-
-
Notifications
You must be signed in to change notification settings - Fork 870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to date-fns v2 #1064
Comments
Awesome! Just tried updating date-fns and came to this repo to see if there are any plans for this :-) |
I'll try and get a beta out with it this week 😄 In the meantime if you want it today you can add this custom date adapter for v2: #963 (comment) |
BREAKING CHANGE: date-fns v2 or higher is now required as a peer dependency If implementing a custom adapter, the `max` function signature has changed to accept an array of dates, instead of an infinite argument list. The date adapters no longer accept strings as input arguments. Closes #1064
I just published a new beta with date-fns v2, please upgrade and try it today with:
|
Just tried |
Awesome, thanks for testing it @Enngage! 😄 |
I just tried if for Angular 7 and it working perfectly Thanks so much |
@mattlewis92 if someone has errors using full-calendar v2 with date-fns v2 upgrade to the beta: |
BREAKING CHANGE: date-fns v2 or higher is now required as a peer dependency If implementing a custom adapter, the `max` function signature has changed to accept an array of dates, instead of an infinite argument list. The date adapters no longer accept strings as input arguments. Closes #1064
BREAKING CHANGE: date-fns v2 or higher is now required as a peer dependency If implementing a custom adapter, the `max` function signature has changed to accept an array of dates, instead of an infinite argument list. The date adapters no longer accept strings as input arguments. Closes #1064
I have problem with new date-fns.
Regards, Tomaž |
@mattlewis92 thx it works with beta version |
@mattlewis92 I had the same problem - shouldn't the date adapter implementations be shipped as a separate module, so angular-calendar has NO dependency to any date library? |
@tom-englert date adapters essentially are already separate modules, but just included in the
and
The only real benefit having them as separate packages would get you is that you could add peer dependencies to date-fns and moment respectively, but that will mostly be solved with optional peer dependencies, and they would have separate versioning from the main package so I could have already released the date-fns v2 adapter as stable already (but you can already use the next version of the calendar with |
I see, I think I had missed a stale import of the date-fns adapter in my code, that's why I got the compile error. |
As it ships ES modules we can finally remove all the deep imports and just import directly from
date-fns
🎉The text was updated successfully, but these errors were encountered: