0.28 #1070
0.28 #1070
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1070 +/- ##
==========================================
+ Coverage 95.77% 96.14% +0.36%
==========================================
Files 37 39 +2
Lines 758 726 -32
Branches 127 119 -8
==========================================
- Hits 726 698 -28
+ Partials 32 28 -4
Continue to review full report at Codecov.
|
|
I just installed |
Awesome, thanks for testing! 😄 |
|
Everything checks out for me on |
|
The only small thing I've noticed style wise is the outline being applied to all .cal-cell and .cal-event classes when focused. Easy to override but thought I'd point it out since it wasn't there in the past. |
Yeah I noticed that as well, it's caused by the new accessibility stuff, I think it should be there by default and then you can just removed it yourself with
Awesome! 😄 |
|
When I have a custom hourSegmentTemplate on the Day View, it shows two segments per row. |
|
It sounds like you're missing edit: ah, looks like the previous day view didn't have that, I'll mark it as a breaking change |
That is indeed it. Definitely should be mentioned in the changelog as a breaking change. |
|
I am also getting flooded by warnings saying:
As far as I can tell, I am not even using |
Are you passing any strings as dates on events? e.g. |
|
I noticed that the time slots on the left hand side on the day view are no longer clickable. This is an issue for me because If I want to schedule an event which is set to begin at the same time as another event, I am unable to click a time since the existing event takes up the width of of that day. If you would like me to make this a separate issue let me know. |
Nice catch! Yeah please make a separate issue and I'll get that fixed up |
mattlewis92
force-pushed
the
0.28
branch
4 times, most recently
from
ca0a0f8 to
d0aaa83
Compare
|
I left a comment on #1083 , but the changes to width calculation on the Day View are a pretty big breaking change design-wise if you have more than just a few events: |
|
Yeah sure, I'll see if there's a way of preserving it. Side note: having that many events on one line isn't really a great UX, I'd highly recommend grouping similar events and then when you click the group it shows all of them in popover or something (you can implement this via a custom event template). That might solve your problem better. |
|
I'll admit, this is somewhat of an edge-case. Grouping is definitely a UX improvement I'll suggest for this visualization. The templating system is very elegant to use to help work around issues like this. |
BREAKING CHANGE: date-fns v2 or higher is now required as a peer dependency If implementing a custom adapter, the `max` function signature has changed to accept an array of dates, instead of an infinite argument list. The date adapters no longer accept strings as input arguments. Closes #1064
BREAKING CHANGE: If extending the week view component the trackBy function `trackByDayOrWeekEvent` was split into `trackByWeekAllDayEvent` and `trackByWeekTimeEvent` Closes #1086
|
Ah, so I realised that displaying events on a fixed width won't actually work with drag and drop or resizing. So I think grouping events is the way to go to solve it, I just pushed up a new demo that shows you how you can go about doing it: https://mattlewis92.github.io/angular-calendar/#/group-similar-events
and here's what it looks like on the 0.28 branch with the day view:
|
|
I just cut the rc release for |
|
|
|
major break!!! custom hourSegmentTemplate using async events not working from this version 0.28.0 - 0.28.16 |
Please try it today and give me feedback before the final release 🎉
There are no more breaking changes planned for
0.28unless something comes up while testing. The only thing the release is waiting on is to add schematics: #888Changelog:
0.28.0
Bug Fixes
Build System
Features
allDayEventsLabelTemplateinput (224848c)BREAKING CHANGES
day-view: If extending the root week view component to override the template you must make the following changes:
Wrap the time events with
<div "class='cal-events-container'">Change
<div class="cal-time-label-column" *ngIf="view.hourColumns.length > 0">to<div class="cal-time-label-column" *ngIf="view.hourColumns.length > 0 && daysInWeek !== 1">Add
[isTimeLabel]="daysInWeek === 1"to the bottom<mwl-calendar-week-view-hour-segment>elementsweek-view: if using a custom
headerTemplateon the week view, then you must now addlet-dragEnter="dragEnter"to the templates variables and(dragEnter)="dragEnter.emit({ date: day.date })"onto themwlDroppableelement.the
columnHeaderClickedoutput on the month view now exposes an object instead of just the ISO day numberBefore:
After:
Any custom styles you used for the day view will need to be adjusted. The
cal-day-view-themesass mixin is now gone as all the styles are shared between the week and day view.The
eventWidthoption is removed, events now fill the available width.If using
[daysInWeek]="1"on the week view, the date and title formatters for the day view will be used instead.The week view now has a border top applied to the top of the component container, rather than the top of the day headers container.
The
getDayViewandgetDayViewHourGridfunctions have been removed from theCalendarUtilsservice.The following interfaces from
calendar-utilswere renamed:DayViewHourSegment->WeekViewHourSegment,DayViewHour->WeekViewHour,DayViewEvent->WeekViewTimeEventThe day view scheduler demo is now based off the week view instead, please check the updated demo code for how to migrate: https://mattlewis92.github.io/angular-calendar/#/day-view-scheduler
If using a custom template for the
hourSegmentTemplate, you must passlet-isTimeLabel="isTimeLabel"as a local variable and then change<div class="cal-time">to<div class="cal-time" *ngIf="isTimeLabel">If implementing a custom adapter, the
maxfunction signature has changed to accept an array of dates, instead of an infinite argument list.The date adapters no longer accept strings as input arguments.