Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #73 and #75: 401 code edge case and exceptions thrown recursively when url is invalid #76

Closed
wants to merge 2 commits into from

Conversation

Raft08
Copy link

@Raft08 Raft08 commented Dec 27, 2023

Hey, Here is the pull request to fix these two issue I found : #75 and #73.

Summary:

  • RateLimiter removes request element from it's iterator when it fails.
  • Added a case check for response code 401 in the Request class

@mattmalec
Copy link
Owner

Let's move these changes into two different PRs. I have some comments on these changes, but I'll address them in your new PRs.

@mattmalec mattmalec closed this Dec 28, 2023
@Raft08
Copy link
Author

Raft08 commented Dec 29, 2023

I will do that when I get the time, and sorry it's my first pull request that actually makes changes in the code of a project that isn't mine.

@Raft08
Copy link
Author

Raft08 commented Jan 12, 2024

First Pull Request #77, I'll wait for it to be reviewed before posting the next one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants