Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix partially matched legend.position #9

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Fix partially matched legend.position #9

merged 1 commit into from
Jan 19, 2024

Conversation

teunbrand
Copy link
Contributor

Hello there,

We have been preparing a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break dynamAedes.

This PR updates a few partially matched legend.position arguments to the theme() function, which should fix check failures due to ggplot2's update.

To test the code changes with the release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled for the 12th of Februari. The progress of the release can be tracked in tidyverse/ggplot2#5588. We hope that this PR might help dynamAedes get out a fix if necessary.

@mattmar mattmar merged commit fae613a into mattmar:master Jan 19, 2024
1 check passed
@teunbrand teunbrand deleted the ggplot2_3.5.0 branch January 19, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants