Create a sample to show how to tag VMs as they are created. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n3wscott
reviewed
Mar 27, 2020
cmd/sample/tag-created-vms/README.md
Outdated
| "context" | ||
| "log" | ||
|
|
||
| cloudevents "github.com/cloudevents/sdk-go/v1" |
There was a problem hiding this comment.
I knew I'd regret inlining that file, that didn't take long.
|
In the next release of cloudevents preview, this changes, we are going to break the contract on client, it will return a Result rather than an error, and you can check for ACK: cloudevents/sdk-go#425 |
mattmoor
force-pushed
the
tag-created-vms
branch
2 times, most recently
from
dd1520a to
0e213a7
Compare
|
I'd rather have the samples in samples/* directory. |
vaikas
reviewed
Mar 27, 2020
mattmoor
force-pushed
the
tag-created-vms
branch
from
0e213a7 to
42688bc
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.