FIX: Remove the client secret from the Keycloak authorization endpoint #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client secret is not used by authorization endpoint, and the client secret should not be visible to user in the browser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix removes the client secret from the Keycloak Authorization endpoint.
The client secret is not used by the authentication request, and the client secret should not be visible to user in the browser.
Tested on an ASP.NET MVC UI application, with a Keycloak client using Standard (code) Flow and Access-Type: confidential.
I have not verified Implicit flow, I am not sure if this library is expected to support that (?).
According to the OpenId Connect specification (used by Keycloak), neither Code, Implicit (nor Hybrid) flow expects a client secret in the authentication request (http://openid.net/specs/openid-connect-core-1_0.html)
When running the library in WebApi mode (which only verifies the bearer token), it should not be affected as it does not do an authentication request itself (as per my understanding)
This is my first real pull request on GitHub, please let me know if the way the branch, commit and pull request were done can be improved :)
#3