Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foursquare Batch Request. #45

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

ptolts
Copy link

@ptolts ptolts commented Nov 27, 2012

I whipped this up really quickly. "search_multiple_venues" allows a user to send up to 5 requests at a time. It might be too ugly to accept, but it gets the idea across.

Thanks for the quality gem, it's come in handy.

@mattmueller
Copy link
Owner

Hey Philip -

Thanks for this. As a starting point could you add a basic test/spec to this? There is definitely still some room for cleanup in this but having a test is probably a good starting point.

Sorry for the late reply.

@ptolts
Copy link
Author

ptolts commented Dec 11, 2012

No problem!

Truthfully I'm totally inexperienced when it comes to writing tests. I'll
try and work something out when I get some time.

Thanks for the input, I'll let you know.

Phil

On Tue, Dec 11, 2012 at 3:04 PM, mattmueller notifications@github.comwrote:

Hey Philip -

Thanks for this. As a starting point could you add a basic test/spec to
this? There is definitely still some room for cleanup in this but having a
test is probably a good starting point.

Sorry for the late reply.


Reply to this email directly or view it on GitHubhttps://github.com//pull/45#issuecomment-11260159.

@alexslade
Copy link

+1 Batch requests (in my case, getting "complete" details on multiple venues at once) would be awesome. I'm in the middle of a hackday right now (using this api!) but will circle around again to check this out and see if I can contribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants