Skip to content

fix: unescaped brackets in path #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2024
Merged

fix: unescaped brackets in path #275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions langserver/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,14 +692,21 @@ func replaceCommandInputFilename(command, fname, rootPath string) string {
ext := filepath.Ext(fname)
ext = strings.TrimPrefix(ext, ".")

command = strings.Replace(command, "${INPUT}", fname, -1)
command = strings.Replace(command, "${INPUT}", escapeBrackets(fname), -1)
command = strings.Replace(command, "${FILEEXT}", ext, -1)
command = strings.Replace(command, "${FILENAME}", filepath.FromSlash(fname), -1)
command = strings.Replace(command, "${ROOT}", rootPath, -1)
command = strings.Replace(command, "${FILENAME}", escapeBrackets(filepath.FromSlash(fname)), -1)
command = strings.Replace(command, "${ROOT}", escapeBrackets(rootPath), -1)

return command
}

func escapeBrackets(path string) string {
path = strings.Replace(path, "(", `\(`, -1)
path = strings.Replace(path, ")", `\)`, -1)

return path
}

func succeeded(err error) bool {
exitErr, ok := err.(*exec.ExitError)
// When the context is canceled, the process is killed,
Expand Down