Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: do not export Writer #68

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

dolmen
Copy link
Contributor

@dolmen dolmen commented Mar 22, 2023

Do not expose symbol Writer. That symbol is purely internal and was only exported on GOOS=windows by mistake.

Currently:

$ GOOS=linux go doc .
package colorable // import "github.com/mattn/go-colorable"

func EnableColorsStdout(enabled *bool) func()
func NewColorable(file *os.File) io.Writer
func NewColorableStderr() io.Writer
func NewColorableStdout() io.Writer
func NewNonColorable(w io.Writer) io.Writer
type NonColorable struct{ ... }
$ GOOS=windows go doc .
package colorable // import "github.com/mattn/go-colorable"

func EnableColorsStdout(enabled *bool) func()
func NewColorable(file *os.File) io.Writer
func NewColorableStderr() io.Writer
func NewColorableStdout() io.Writer
func NewNonColorable(w io.Writer) io.Writer
type NonColorable struct{ ... }
type Writer struct{ ... }

Do not expose symbol 'Writer'. That symbol is purely internal and was only
exported on GOOS=windows.
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.33%. Comparing base (11a925c) to head (8e4a944).
Report is 6 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #68       +/-   ##
===========================================
+ Coverage    6.33%   83.33%   +77.00%     
===========================================
  Files           3        2        -1     
  Lines         600       42      -558     
===========================================
- Hits           38       35        -3     
+ Misses        561        6      -555     
  Partials        1        1               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattn mattn merged commit 9473000 into mattn:master Mar 22, 2023
@mattn
Copy link
Owner

mattn commented Mar 22, 2023

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants