-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go test fails with go1.5 #232
Comments
I just tried running |
did you try in latest go-sqlite3? |
I do have a very similar problem. If I run func CreateVirtualQuestions(vDb *sql.DB) (VirtualQuestions, error) {
errors := make(chan error)
var vq VirtualQuestions
vq.connection = vDb
go func() {
rows, err := vDb.Query(`SELECT * FROM questions ORDER BY RANDOM()`)
if err != nil {
log.Print("1")
log.Fatal(err)
errors <- err
}
vq.RandomQuestions = rows
}()
go func() {
rows, err := vDb.Query(`SELECT * FROM questions WHERE faculty = "medicin" ORDER BY RANDOM()`)
if err != nil {
log.Print("2")
log.Fatal(err)
errors <- err
}
vq.RandomMedicin = rows
}()
go func() {
rows, err := vDb.Query(`SELECT * FROM questions WHERE part = "logic" ORDER BY RANDOM()`)
if err != nil {
log.Print("3")
log.Fatal(err)
errors <- err
}
vq.RandomLogic = rows
}()
go func() {
rows, err := vDb.Query(`SELECT * FROM questions WHERE part = "math" ORDER BY RANDOM()`)
if err != nil {
log.Print("4")
log.Fatal(err)
errors <- err
}
vq.RandomMath = rows
}()
go func() {
rows, err := vDb.Query(`SELECT * FROM questions WHERE part = "biology" ORDER BY RANDOM()`)
if err != nil {
log.Print("5")
log.Fatal(err)
errors <- err
}
vq.RandomBiology = rows
}()
go func() {
rows, err := vDb.Query(`SELECT * FROM questions WHERE part = "chemistry" ORDER BY RANDOM()`)
if err != nil {
log.Print("6")
log.Fatal(err)
errors <- err
}
vq.RandomChemistry = rows
}()
go func() {
rows, err := vDb.Query(`SELECT * FROM questions WHERE part = "physic" ORDER BY RANDOM()`)
if err != nil {
log.Print("2")
log.Fatal(err)
errors <- err
}
vq.RandomPhysic = rows
}()
return vq, nil
} each goroutines runs a query and puts the rows in a structure. $ go version
go version go1.6 linux/amd64 |
What error did you get on 1.5? |
Sorry, I tried only on the 1.6 The error says it doesn't find the table. |
Are you by chance using an in memory (":memory:") database? If so you should see #204 |
@tscholl2 yes I am Thank you :) Fix it :) |
Compile Section Closes mattn#175 Compile Section Closes mattn#201 Compile Section Closes mattn#206 Compile Section Closes mattn#404 Compile Section Closes mattn#217 Compile Section Closes mattn#224 Compile Section Closes mattn#234 Compile Section Closes mattn#242 Feature table Closes mattn#255 Description Section Closes mattn#232 Golang:1.6 not supported Closes mattn#272 Golang:1.5 not supported + compilation section Closes mattn#283 usleep Implemented Closes mattn#285 FAQ Section Closes mattn#289 Compile Section closes mattn#295 FAQ Section Closes mattn#305 PR339 Closes mattn#318 mattn#321 Compilation Section Closes mattn#341 PR407 Closes mattn#364 Feature `sqlite_vtable` Closes mattn#393 Compile Section Closes mattn#416 sqlite_trace feature Closes mattn#433 Compilation Section Closes mattn#435 Compilation Section Closes mattn#443 Golang:1.6 Not Supported Closes mattn#445 Compilation Section Closes mattn#451 Compilation Section Closes mattn#467 Compilation Section Closes mattn#491 Compilation Section Closes mattn#495 Compilation Section Closes mattn#505 Compilation Section Closes mattn#557 Compilation Section Closes mattn#560
I'm curious if this is happening to anyone else.
I built go1.5 from source, bootstrapping with go1.4. When I run
go test -short
using go1.5, I get the following output.It works fine when I use go1.4 though.
The failing test is in
sqlite3_test/sqltest.go
. If I remove the concurrency by changing it like so:It works just fine, which implies it's thread safety related. Perhaps https://golang.org/doc/go1.5#runtime could've affected it?
The text was updated successfully, but these errors were encountered: