-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected minor typos for ease of understanding #1098
Open
robertjamison
wants to merge
1
commit into
mattn:master
Choose a base branch
from
robertjamison:robertjamison
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not a significant update, but should be included in the next distro.
rittneje
reviewed
Oct 18, 2022
// | ||
// From SQLITE3 - user-auth.txt | ||
// The sqlite_user.pw field is encoded by a built-in SQL function | ||
// "sqlite_crypt(X,Y)". The two arguments are both BLOBs. The first argument | ||
// is the plaintext password supplied to the sqlite3_user_authenticate() | ||
// interface. The second argument is the sqlite_user.pw value and is supplied | ||
// so that the function can extract the "salt" used by the password encoder. | ||
// The result of sqlite_crypt(X,Y) is another blob which is the value that | ||
// The result of sqlite_crypt(X,Y) is another blob, which is the value that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These paragraphs are copied directly from here: https://www.sqlite.org/src/doc/trunk/ext/userauth/user-auth.txt
rittneje
reviewed
Oct 18, 2022
@@ -13,24 +13,24 @@ import ( | |||
|
|||
// This file provides several different implementations for the | |||
// default embedded sqlite_crypt function. | |||
// This function is uses a caesar-cypher by default | |||
// This function includes a caesar-cypher by default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
// This function includes a caesar-cypher by default | |
// This function uses a Caesar cipher by default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a significant update. I'm really just trying to make my first contribution ever on GitHub.
Feel free to add to the next update.