Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating vtable example, "BestIndex" method #1099

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Conversation

dvas0004
Copy link
Contributor

As it was, the vtable example will give an error when adding any kind of SQL constraint in the SQL statement. Updating the BestIndex method will ensure that adding SQL constraints will not result in errors

Signed-off-by: David Vassallo davevassallo@gmail.com

As it was, the vtable example will give an error when adding any kind of SQL constraint in the SQL statement. Updating the BestIndex method will ensure that adding SQL constraints will not result in errors

Signed-off-by: David Vassallo <davevassallo@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2022

Codecov Report

Base: 45.96% // Head: 46.09% // Increases project coverage by +0.13% 🎉

Coverage data is based on head (79a80cc) compared to base (90900be).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1099      +/-   ##
==========================================
+ Coverage   45.96%   46.09%   +0.13%     
==========================================
  Files          11       11              
  Lines        1499     1499              
==========================================
+ Hits          689      691       +2     
+ Misses        670      669       -1     
+ Partials      140      139       -1     
Impacted Files Coverage Δ
sqlite3.go 52.86% <0.00%> (+0.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rittneje rittneje merged commit 4b8633c into mattn:master Oct 18, 2022
patrickdevivo referenced this pull request in mergestat/mergestat Oct 26, 2022
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/mattn/go-sqlite3](https://togithub.com/mattn/go-sqlite3) |
require | patch | `v1.14.15` -> `v1.14.16` |

---

### Release Notes

<details>
<summary>mattn/go-sqlite3</summary>

###
[`v1.14.16`](https://togithub.com/mattn/go-sqlite3/releases/tag/v1.14.16)

[Compare
Source](https://togithub.com/mattn/go-sqlite3/compare/v1.14.15...v1.14.16)

#### What's Changed

- Add build tag to enable OSTRACE() logging by
[@&#8203;benbjohnson](https://togithub.com/benbjohnson) in
[https://github.com/mattn/go-sqlite3/pull/1067](https://togithub.com/mattn/go-sqlite3/pull/1067)
- TestQueryer: actually check Rows returned by
[@&#8203;ohwgiles](https://togithub.com/ohwgiles) in
[https://github.com/mattn/go-sqlite3/pull/1062](https://togithub.com/mattn/go-sqlite3/pull/1062)
- Update README to fix reference URL by
[@&#8203;shibukawa](https://togithub.com/shibukawa) in
[https://github.com/mattn/go-sqlite3/pull/1082](https://togithub.com/mattn/go-sqlite3/pull/1082)
- Fix test queryer test by
[@&#8203;joshbuddy](https://togithub.com/joshbuddy) in
[https://github.com/mattn/go-sqlite3/pull/1079](https://togithub.com/mattn/go-sqlite3/pull/1079)
- Rollback on constraint failure by
[@&#8203;joshbuddy](https://togithub.com/joshbuddy) in
[https://github.com/mattn/go-sqlite3/pull/1071](https://togithub.com/mattn/go-sqlite3/pull/1071)
- Fix "ennviroment" by
[@&#8203;RewardedIvan](https://togithub.com/RewardedIvan) in
[https://github.com/mattn/go-sqlite3/pull/1077](https://togithub.com/mattn/go-sqlite3/pull/1077)
- こんにちわ is wrong Japanse, Correct word is こんにちは by
[@&#8203;KiYugadgeter](https://togithub.com/KiYugadgeter) in
[https://github.com/mattn/go-sqlite3/pull/1085](https://togithub.com/mattn/go-sqlite3/pull/1085)
- Add test for sqlite_math_functions tag by
[@&#8203;lggruspe](https://togithub.com/lggruspe) in
[https://github.com/mattn/go-sqlite3/pull/1059](https://togithub.com/mattn/go-sqlite3/pull/1059)
- remove unuseful ldflags for windows platform. by
[@&#8203;kkqy](https://togithub.com/kkqy) in
[https://github.com/mattn/go-sqlite3/pull/1084](https://togithub.com/mattn/go-sqlite3/pull/1084)
- Cross Compiling for Mac OS via `musl-cross` by
[@&#8203;jodosha](https://togithub.com/jodosha) in
[https://github.com/mattn/go-sqlite3/pull/1090](https://togithub.com/mattn/go-sqlite3/pull/1090)
- Update README.md to include vtable feature by
[@&#8203;dvas0004](https://togithub.com/dvas0004) in
[https://github.com/mattn/go-sqlite3/pull/1100](https://togithub.com/mattn/go-sqlite3/pull/1100)
- Updating vtable example, "BestIndex" method by
[@&#8203;dvas0004](https://togithub.com/dvas0004) in
[https://github.com/mattn/go-sqlite3/pull/1099](https://togithub.com/mattn/go-sqlite3/pull/1099)
- Update amalgamation code by
[@&#8203;mattn](https://togithub.com/mattn) in
[https://github.com/mattn/go-sqlite3/pull/1104](https://togithub.com/mattn/go-sqlite3/pull/1104)

#### New Contributors

- [@&#8203;ohwgiles](https://togithub.com/ohwgiles) made their first
contribution in
[https://github.com/mattn/go-sqlite3/pull/1062](https://togithub.com/mattn/go-sqlite3/pull/1062)
- [@&#8203;shibukawa](https://togithub.com/shibukawa) made their first
contribution in
[https://github.com/mattn/go-sqlite3/pull/1082](https://togithub.com/mattn/go-sqlite3/pull/1082)
- [@&#8203;joshbuddy](https://togithub.com/joshbuddy) made their first
contribution in
[https://github.com/mattn/go-sqlite3/pull/1079](https://togithub.com/mattn/go-sqlite3/pull/1079)
- [@&#8203;RewardedIvan](https://togithub.com/RewardedIvan) made their
first contribution in
[https://github.com/mattn/go-sqlite3/pull/1077](https://togithub.com/mattn/go-sqlite3/pull/1077)
- [@&#8203;KiYugadgeter](https://togithub.com/KiYugadgeter) made their
first contribution in
[https://github.com/mattn/go-sqlite3/pull/1085](https://togithub.com/mattn/go-sqlite3/pull/1085)
- [@&#8203;lggruspe](https://togithub.com/lggruspe) made their first
contribution in
[https://github.com/mattn/go-sqlite3/pull/1059](https://togithub.com/mattn/go-sqlite3/pull/1059)
- [@&#8203;kkqy](https://togithub.com/kkqy) made their first
contribution in
[https://github.com/mattn/go-sqlite3/pull/1084](https://togithub.com/mattn/go-sqlite3/pull/1084)
- [@&#8203;jodosha](https://togithub.com/jodosha) made their first
contribution in
[https://github.com/mattn/go-sqlite3/pull/1090](https://togithub.com/mattn/go-sqlite3/pull/1090)
- [@&#8203;dvas0004](https://togithub.com/dvas0004) made their first
contribution in
[https://github.com/mattn/go-sqlite3/pull/1100](https://togithub.com/mattn/go-sqlite3/pull/1100)

**Full Changelog**:
mattn/go-sqlite3@v1.14.15...v1.14.16

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click
this checkbox.

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/mergestat/mergestat).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xLjUiLCJ1cGRhdGVkSW5WZXIiOiIzNC4xLjUifQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants