callback: use handles rather than passing Go pointers #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cgo pointer passing rules forbid passing a Go pointer to C if that pointer points to memory containing other Go pointers. This is true even if the Go pointer is converted to uintptr. This change fixes the code to use a handle instead, and to look up the handle in the callback function.
ianlancetaylor
referenced
this pull request
Jan 31, 2016
|
Somehow, I had expected the patch. And also I just sure that the fixes against cgoCheckPointer will be large for another projects too. Thank you very much. And Sorry for taking your precious time. |
mattn
added a commit
that referenced
this pull request
Jan 31, 2016
callback: use handles rather than passing Go pointers
vanadium-bot
pushed a commit
to vanadium-archive/third_party
that referenced
this pull request
Mar 14, 2016
Motivation: To make things work with Go 1.6 Specifically to get this mattn/go-sqlite3#267 and mattn/go-sqlite3#268 Change-Id: I66daa419daebfddf1382ade56af4d1806eebf409
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cgo pointer passing rules forbid passing a Go pointer to C if that
pointer points to memory containing other Go pointers. This is true
even if the Go pointer is converted to uintptr.
This change fixes the code to use a handle instead, and to look up the
handle in the callback function.