Run dlv from a temporary directory #3
Conversation
|
I think this approach is better @mattn? What do you think of it? |
autoload/go/debug.vim
Outdated
| " current dir. We pass --wd= so the binary is still run from the current | ||
| " dir. | ||
| let original_dir = getcwd() | ||
| let tmp = fnamemodify(tempname(), ':h') |
There was a problem hiding this comment.
let tempfile = tempname()
let tmpdir = fnamemodify(tempfile, ':h')
call delete(tempfile)
There was a problem hiding this comment.
Alright, I'll change that in a minute 👍
Would you mind rebasing your godebug branch on the latest master btw? Then I have the bugfix for go#package#FromPath() so I can test it to make sure I didn't make a stupid mistake :-)
There was a problem hiding this comment.
Looking at this again, I think your intent was to make sure that Vim creates a directory in /tmp/<random>? It already does that; the return value from tempname() is /tmp/<random>/<n>, where <random> seems stable for every Vim session and n is a sequential number.
So I think that the current version already does what you want? Write file to /tmp/<random>/<pkgname>?
There was a problem hiding this comment.
tempname() doesn't create directory (at least on Windows)
There was a problem hiding this comment.
Sorry tempname() doesn't create file too.
There was a problem hiding this comment.
How about this?
let tmpdir = filter([$TEMP, $TMP, $TMPDIR], '!empty(v:val)')[0] . '/' . sha256(fnamemodify(bufname(''), ":p"))
call mkdir(tmpdir, "p", 0700)There was a problem hiding this comment.
Ah, I didn't know it behaves different on Windows. I updated it with something that should work on both platforms (but I didn't test on Windows, as I don't have a Windows computer!)
This fixes two things: - My comments here: fatih@8d617ec#r138018608 It's true that `:lcd` is only for the current window, but me personally I still wouldn't expect any user-visible changes in the current directory when using `:GoDebugStart`. - It prevents `dlv` from creating a binary in the directory. At best this is an annoying side-effect, but at worst it could cause people to lose files: consider what would happen if someone has a package named `foo` but also had a file named `foo` in that directory? If you always use `go install` (like I do) then this is fine, and `:GoDebugStart` creating this file can be rather surprising. Note: this PR requires this patch to work correctly: fatih#1435
Since tempnam() seems to behave different on Linux and Windows.
| function! go#util#tempdir(prefix) abort | ||
| " See :help tempfile | ||
| if go#util#IsWin() | ||
| let l:dirs = [$TMP, $TEMP, 'c:\tmp', 'c:\temp'] |
There was a problem hiding this comment.
Ah sorry. my mistake. Ignore this.
This fixes two things:
My comments here:
fatih@8d617ec#r138018608
It's true that
:lcdis only for the current window, but mepersonally I still wouldn't expect any user-visible changes in the
current directory when using
:GoDebugStart.It prevents
dlvfrom creating a binary in the directory. At bestthis is an annoying side-effect, but at worst it could cause people to
lose files: consider what would happen if someone has a package named
foobut also had a file namedfooin that directory?If you always use
go install(like I do) then this is fine, and:GoDebugStartcreating this file can be rather surprising.Note: this PR requires this patch to work correctly:
fatih#1435