-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] NOTIFY Command #64
Conversation
Tests currently fail due to djc/imap-proto#2. LSUB is also broken due to djc/imap-proto#4 (but we don't have tests for that atm).
All tests now pass
Structured
@jonhoo Hey, it would be nice if you could take another look at the code. I implemented all that has been missing (for now) and also your suggestions. Test runs fine and an actual test against an actual IMAP server with quite a few mailboxes also works. |
Hey, sorry, I completely dropped the ball on this one! Can you match up with |
Hey, no problem. I've been busy with offline stuff anyway. I just matched up with master but I haven't looked into the structured responses and |
It'd be nice if you could rebase this onto |
@jkaessens I've had to move the repository under my own control so that I can set up CI and such correctly following the resolution to #69. Could you please open this PR up again against https://github.com/jonhoo/rust-imap instead? Including a link back to this for reference would probably also be a good idea! |
Once finished, this implements the
IMAP NOTIFY
extensions as discussed in issue #63. Currently work in progress.Todo:
STATUS
responses in mailbox parser (done in 5d19d4f)NOTIFY SET STATUS
whereSTATUS
es are sent right after theNOTIFY
command (done in f6b6c96)STATUS
es (done in 6e48c77)ZeroCopyResult