chore: improve Configure TypeScript section in the readme #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrazauskas
commented
Aug 28, 2023
| @@ -22,7 +22,7 @@ Thanks for being willing to contribute! | |||
|
|
|||
| Once you are ready to commit the changes, please use the below commands | |||
|
|
|||
| 1. `git add <files to be comitted>` | |||
| 1. `git add <files to be committed>` | |||
There was a problem hiding this comment.
Just a typo. Could not leave it, sorry.
| ```json | ||
| { | ||
| "devDependencies": { | ||
| "@types/jest-expect-message": "npm:jest-expect-message@*", |
There was a problem hiding this comment.
The inspiration for this solution was the Supporting lib from node_modules section from TypeScript 4.5 release notes. The usage of npm: protocol looked smart. I tried out the same approach with @types/* package declaration and it worked! Well.. Looks obvious, but that was rather a discovery for me ;D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR is a suggestion to improve Configure TypeScript section in the readme.
Why
Technically there is no problem, all works well as documented. It just does not look elegant to reach into
node_modulesinstead of letting package manager and TypeScript do the job. The improvement is subjective, of course.Housekeeping