fix log message not displaying when referencing missing bidder (prebi…

…d#1737) * fix log message not displaying when referencing missing bidder * add test for missing bidder log message * move test to adaptermanager_spec
mattpr · Oct 31, 2017 · 00b8512 · 00b8512
1 parent 4f0f918
commit 00b8512
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 8 deletions.
diff --git a/src/adaptermanager.js b/src/adaptermanager.js
@@ -197,20 +197,18 @@ exports.callBids = ({adUnits, cbTimeout}) => {
  $$PREBID_GLOBAL$$._bidsRequested.push(bidderRequest);
  _bidderRequests.push(bidderRequest);
  }
+ } else {
+ utils.logError(`Adapter trying to be called which does not exist: ${bidderCode} adaptermanager.callBids`);
  }
  });
 
  _bidderRequests.forEach(bidRequest => {
  bidRequest.start = new Date().getTime();
  const adapter = _bidderRegistry[bidRequest.bidderCode];
- if (adapter) {
- if (bidRequest.bids && bidRequest.bids.length !== 0) {
- utils.logMessage(`CALLING BIDDER ======= ${bidRequest.bidderCode}`);
- events.emit(CONSTANTS.EVENTS.BID_REQUESTED, bidRequest);
- adapter.callBids(bidRequest);
- }
- } else {
- utils.logError(`Adapter trying to be called which does not exist: ${bidRequest.bidderCode} adaptermanager.callBids`);
+ if (bidRequest.bids && bidRequest.bids.length !== 0) {
+ utils.logMessage(`CALLING BIDDER ======= ${bidRequest.bidderCode}`);
+ events.emit(CONSTANTS.EVENTS.BID_REQUESTED, bidRequest);
+ adapter.callBids(bidRequest);
  }
  })
 };

diff --git a/test/spec/unit/core/adapterManager_spec.js b/test/spec/unit/core/adapterManager_spec.js
@@ -34,6 +34,30 @@ var appnexusAdapterMock = {
 };
 
 describe('adapterManager tests', () => {
+ describe('callBids', () => {
+ beforeEach(() => {
+ sinon.stub(utils, 'logError');
+ });
+
+ afterEach(() => {
+ utils.logError.restore();
+ });
+
+ it('should log an error if a bidder is used that does not exist', () => {
+ const adUnits = [{
+ code: 'adUnit-code',
+ bids: [
+ {bidder: 'appnexus', params: {placementId: 'id'}},
+ {bidder: 'fakeBidder', params: {placementId: 'id'}}
+ ]
+ }];
+
+ AdapterManager.callBids({adUnits});
+
+ sinon.assert.called(utils.logError);
+ });
+ });
+
  describe('S2S tests', () => {
  beforeEach(() => {
  AdapterManager.setS2SConfig(CONFIG);