Use PixelCopy API when supported #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattprecious
commented
Nov 5, 2024
| Bitmap screenshot = Bitmap.createBitmap(view.getDrawingCache()); | ||
| view.setDrawingCacheEnabled(false); | ||
| Window window = findWindow(); | ||
| if (Build.VERSION.SDK_INT >= 26 && view != this && window != null) { |
There was a problem hiding this comment.
view != this isn't correct. Gotta fix this logic.
mattprecious
force-pushed
the
mattp/2024-11-05/pixelcopy
branch
from
1011d59 to
0e4fe2f
Compare
This supports hardware rendering.
mattprecious
force-pushed
the
mattp/2024-11-05/pixelcopy
branch
from
0e4fe2f to
5fb59f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports hardware rendering.
Fixes #142, but only on API 26+. Not sure if there's anything we can do for earlier versions.