Skip to content

Commit

Permalink
gh: tests: do not change workdir in docker
Browse files Browse the repository at this point in the history
Some files -- e.g. LCOV -- might write the absolute full path in their
tracking files. If we set a different path in Docker, we need to fix
that when being out of it. Instead, we can use the same paths in and out
the docker.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
  • Loading branch information
matttbe committed Sep 26, 2024
1 parent a96d690 commit 29818ea
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@ jobs:
-e "INPUT_GCOV=1" \
-e "GITHUB_SHA" -e "GITHUB_REF_NAME" -e "GITHUB_RUN_ID" \
-e GITHUB_ACTIONS=true -e CI=true \
--workdir /github/workspace \
-v "${PWD}":"/github/workspace" \
--workdir "${PWD}" \
-v "${PWD}:${PWD}" \
mptcp/mptcp-upstream-virtme-docker:${{ steps.branch.outputs.name == 'export' && 'latest' || 'net' }} \
auto-${{ matrix.mode }}
Expand Down Expand Up @@ -326,8 +326,8 @@ jobs:
rm -rf "${out}"
mkdir -p "${out}"
/usr/bin/docker run --pull always --rm \
--workdir /github/workspace \
-v "${PWD}":"/github/workspace" \
--workdir "${PWD}" \
-v "${PWD}:${PWD}" \
mptcp/docker-lcov-alpine:latest \
genhtml -j "$(nproc)" -t "${{ github.ref_name }}" \
--dark-mode --legend \
Expand Down

0 comments on commit 29818ea

Please sign in to comment.