Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fairly straightforward, except that unlike other models supported so far, this one seems to require that the main frequency sent over the wire includes a decimal point. A summary of my troubleshooting follows.
Main wave Frequency must be represented in decimal Hz, not uHz as in previous models.
Summary of the Issue
Put another way, the resolution of the main wave frequency is still 1 uHz as in other FeelTech generators, but when sending the frequency over the wire, you must include a decimal point (making the resulting string appear to be represented in decimal Hz).
For instance, to set the frequency to 123.4 kHz,
FYGen
would typically send:WMF00001234000000
1234000000 uHz = 1234 Hz = 1.234 kHz
...but to the FY6300, this appears to be asking for:
1234000000 Hz = 1.234 GHz
... which is of course too large and the FY6300 just sets its frequency to the maximum (50MHz in this case).
Sending the frequency with a decimal (e.g.
WMF01234.000000
) makes the FY6300 correctly interpret it as:1234 Hz = 1.234 kHz
Troubleshooting Setup
Troubleshooting Examples:
Can go lower than 1Hz by including the decimal point:
Minimum Possible:
Modulation
Modulation frequency parameters like
hop_freq_hz
(commandWFK
) andfm_bias_freq_hz
(commandWFM
) do not seem to require special treatment for the fy6300.