Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more info to exception #23

Closed
PhilipMay opened this issue Jun 9, 2022 · 0 comments
Closed

Add more info to exception #23

PhilipMay opened this issue Jun 9, 2022 · 0 comments

Comments

@PhilipMay
Copy link
Collaborator

What about adding stderr.decode("utf-8") to the exception text - and not just printing it?

prometheus-smartctl/smartprom.py

Line 30 in 3fbd7bb

raise Exception('Command returned code {}'.format(out.returncode))

ngosang added a commit to ngosang/prometheus-smartctl that referenced this issue Jul 27, 2022
@ngosang
Return more information on smartctl error. Resolves matusnovak#23
2bae023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PhilipMay