Using SMART tool to get the devices instead of glob #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed variable TYPES since it is no longer used
Removed the if statement, because
- TYPES are no longer used
- DEVICES is now a dictionary containing
device name and its type
Removed unused codes
ngosang
approved these changes
Jul 27, 2022
|
Thank you @Jopaul-John |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code uses a regular expression to get the drives in the system. This can lead to finding unsupported smartctl drives like USB/Virtual drives. So instead, a better way is to use the smartctl
scanfunctionality that will only fetch the drives which are compatible.Removed variable TYPES since it is no longer used
Removed the if statement, because
- TYPES are no longer used
- DEVICES is now a dictionary containing
device name and its type
Removed unused codes