Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #33

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

IboKhaled
Copy link
Contributor

Add getting started section
Add notice that master is broken as of late 2023

README.md Outdated
@@ -5,6 +5,22 @@
# libopenvizsla
An attempt to reimplement [OpenVizsla](http://openvizsla.org/) host software in plain C.

## Getting Started
This section describes how to get started with OpenVizsla and Wireshark. \
**IMPORTANT NOTICE:** As of late 2023, master is broken (see [#30](https://github.com/matwey/libopenvizsla/pull/30#issuecomment-1501915611)). Use Tag/Release 0.1.1 instead.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi.

First of all, thank you for the contribution.

If you feel that something is broken, please open new issue instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current master gets out of sync and I do not really have time to debug it. As an intermediate solution, you can either use earlier master version or if you want to benefit from new bitstream use the original version of #30 (i.e. prior to master changes) that I pushed to a branch at my fork: https://github.com/desowin/libopenvizsla/tree/update-bitstream-working

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug mentioned here is fixed in #34

README.md Outdated
3. Run Wireshark and start capturing

### Windows
1. Make sure `FTDI D2XX` drivers are installed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need for FTDI drivers because libusbK is being used. The FTDI drivers may only be necessary if you are building brand new OpenVizsla and have to program the EEPROM (but this is not supported here, only in ov_ftdi python code).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hint, removed!

Add getting started section
@IboKhaled IboKhaled force-pushed the feature/updateDocumentation branch from 2922a79 to 99fbbac Compare February 13, 2024 12:21
@IboKhaled
Copy link
Contributor Author

Sorry for not responding for so long.
I've removed the broken master notice and the FTDI driver requirement. Please reevaluate the merge.

Thank you for the amazing project, it has worked very well and without issues for me after getting it all set up!

@matwey matwey merged commit bfb6849 into matwey:master Feb 13, 2024
8 checks passed
@matwey
Copy link
Owner

matwey commented Feb 13, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants