Skip to content

Conversation

@PerfectedApp
Copy link

This could be cleaned up. I ran through this as fast as possible. If you guys dont have time to clean it up, it will be awhile before I can get to it.

The stating of the lazy resources is still in the routes config. Feel free to move it to the controller level.

Example:
(template, mainController, otherControllers, {directives, services})
$routeProvider.when('/view1', routeConfig.config('../partials/view1.html', 'controllers/first', null, {directives: ['directives/version'], services: ['services/tester']}));

Use this as a guide to extend for other resources... current "services" is value provide only.
(already done)$provide.value('a', 123);
$provide.factory('a', function() { return 123; });
(already done) $compileProvider.directive('directiveName', ...);
$filterProvider.register('filterName', ...);

@PerfectedApp
Copy link
Author

Another problem that needs to be addressed: lazy resources are not disposed when they should be. If a service is registered, it lives for the life of the app session, regardless of which routes are defined for that resource.

@PerfectedApp
Copy link
Author

I ran out of time for this right now. There's still a bug with resources not disposing.

@matys84pl
Copy link
Owner

Hi, first of all thanks for your effort. Is there a chance you could squash your commits into one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants