-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on node-stringprep #16
Comments
After discussion with @Arachnid based on the following research, we've decided to keep current dependency until it actually causes an issue that forces us to invest the effort required to replaces this. Nameprep searchIssueCannot find a maintained implementation of name prep for the registrar package Options1. Use existing libraries:Search terms used include: stringprep, nameprep, IDN, IDNA, IETF, RFC
2. Reimplement NameprepTables from stringprep
Background:
Nameprep NFKC: Internationalized domain names in applications: Refs: |
* Use random secret for bid * Flatten bid object Or else it can get confusing if you should use bid (the mongo object) or bid.bid (the object generated by registrar.bidFactory). Also, remove duplicate properties. * Stronger secret value * change bid placement * fixes download button
It has a lot of build issues: xmppo/node-stringprep#94
The text was updated successfully, but these errors were encountered: