Add support Symfony 5 for controller

[pasxel]

Fixing error on Mautic 5.0.0-alpha1 branch.

[Symfony\Component\ErrorHandler\Error\ClassNotFoundError]                                         
  Attempted to load class "Controller" from namespace "Symfony\Bundle\FrameworkBundle\Controller".  
  Did you forget a "use" statement for another namespace?

For reproducing just run php bin/console debug:route on branch 5.0.0-alpha1

[escopecz]

I can replicate.

Do you have some steps to test? I tried this:

1. Update the line in https://github.com/mautic/mautic/blob/5.x/app/composer.json#L122 to "url": "https://github.com/pasxel/SpBundle.git"
2. Run composer update --lock in the Mautic root dir

But it didn't update the package.

[patrykgruszka]

@pasxel please provide the steps how to test this PR

[pasxel]

To test I used:

• Update the line in https://github.com/mautic/mautic/blob/5.x/app/composer.json#L122 to "url": "https://github.com/pasxel/SpBundle.git"
• Update the line in https://github.com/mautic/mautic/blob/5.x/composer.json#L104 to "url": "https://github.com/pasxel/SpBundle.git"
• Run composer update --lock in the app dir and project dir

It should update vendors.

[mollux]

@escopecz you need to update the repo override in the root composer.json, not in the app/composer.json.
That will correctly pull from the wanted source

[patrykgruszka]

@pasxel I haven't been able to test this with your example. The composer probably pulled the changes from the master branch. I've replaced the code directly in the vendor and the command works after your changes:

ddev exec php bin/console debug:router                                                                                                                                                                                                                    
 -------------------------------------------- ---------------- -------- ------ ------------------------------------------------------------------------------------------------- 
  Name                                         Method           Scheme   Host   Path                                                                                             
 -------------------------------------------- ---------------- -------- ------ ------------------------------------------------------------------------------------------------- 
  _wdt                                         ANY              ANY      ANY    /_wdt/{token}                                                                                    
  _profiler_home                               ANY              ANY      ANY    /_profiler/     
...

[mollux]

fixes and improvements make sense, and they solve the issue!

[escopecz]

Thanks everyone! Is there anything blocking the merge?

[mollux]

@escopecz somehow i have no write access, so please go ahead merging :)

[mautibot]

This pull request has been mentioned on Mautic Forums. There might be relevant details there:

https://forum.mautic.org/t/mautic-5-beta-1-saml-not-working/29653/5

[petecodes123]

Hi all,

How can I resolve this issue with my current Mautic 5.0.3 installation ?

[escopecz]

@petecodes123 this was fixed in Mautic 5.0.3 with mautic/mautic#13253. If you've installed Mautic with Composer, try to run composer install. It won't hurt to try that.