-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Point Trigger edit and delete buttons are not visible #14412 #14617
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.2 #14617 +/- ##
=========================================
Coverage 63.56% 63.56%
Complexity 34637 34637
=========================================
Files 2273 2273
Lines 103619 103619
=========================================
Hits 65870 65870
Misses 37749 37749 |
First of all: nice idea that I can recover my deletions until I save. But if I delete something and click just on save the Event is still there (not editable but there). After Save and Quit und reopen the Trigger its away. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's doing what it should, thank you for the fix
Screencast.From.2025-02-19.11-15-39.mp4
@RCheesley @andersonjeccel is everything fine or should i change anything |
@Bastian2718 not sure I am following your findings - could you share a screen recording to help us better understand? Thanks! |
yeah @Bastian2718 could you please screen record and share the issue you are facing |
PointTrigger.mp4Delete -> Save -> Still there but not editable -> Save And Quit -> Still there |
https://www.loom.com/share/91640e9632e8466e80f68927aab66fa5?sid=37cbef04-0795-4bc8-9601-9e2d8801126f |
@RCheesley and @andersonjeccel could you please verify whether you are facing an issue which @Bastian2718 mentioned and everything is working fine for me |
@rishithreddy89 I checked again. My Issue only happens when the Trigger is already existing and I edit it. |
@Bastian2718 The behavior you're seeing is a different (unrelated) bug, thank you for flagging it! |
This PR can be merged |
Description
📋 Steps to test this PR: