Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point Trigger edit and delete buttons are not visible #14412 #14617

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

rishithreddy89
Copy link
Contributor

@rishithreddy89 rishithreddy89 commented Feb 19, 2025

Q A
Bug fix? (use the 5.2 branch) ✔️
New feature/enhancement? (use the a.x branch)
Deprecations?
BC breaks? (use the c.x branch)
Automated tests included? ✔️
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #14412 ...

Description

Before After
Before After
Before image After image

📋 Steps to test this PR:

  1. In points open manage trigger
  2. click on new button
  3. now open events section
  4. add an event
  5. previously it was difficult to remove field when we hover on to them
  6. In this pr i fixed that issue
  7. now users can easily delete event on hovering them
  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.56%. Comparing base (c050d2b) to head (ed48222).
Report is 6 commits behind head on 5.2.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                5.2   #14617   +/-   ##
=========================================
  Coverage     63.56%   63.56%           
  Complexity    34637    34637           
=========================================
  Files          2273     2273           
  Lines        103619   103619           
=========================================
  Hits          65870    65870           
  Misses        37749    37749           

@Bastian2718
Copy link

First of all: nice idea that I can recover my deletions until I save. But if I delete something and click just on save the Event is still there (not editable but there). After Save and Quit und reopen the Trigger its away.

Copy link
Contributor

@andersonjeccel andersonjeccel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's doing what it should, thank you for the fix

Screencast.From.2025-02-19.11-15-39.mp4

@andersonjeccel andersonjeccel added T1 Low difficulty to fix (issue) or test (PR) user-interface Anything related to appearance, layout, and interactivity ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged regression A bug that broke something in the last release points-scoring Anything related to points code-review-passed PRs which have passed code review user-testing-passed PRs which have been successfully tested by the required number of people. labels Feb 19, 2025
@andersonjeccel andersonjeccel added this to the 5.2.3 milestone Feb 19, 2025
@rishithreddy89
Copy link
Contributor Author

@RCheesley @andersonjeccel is everything fine or should i change anything

@RCheesley
Copy link
Member

@Bastian2718 not sure I am following your findings - could you share a screen recording to help us better understand? Thanks!

@rishithreddy89
Copy link
Contributor Author

yeah @Bastian2718 could you please screen record and share the issue you are facing

@Bastian2718
Copy link

PointTrigger.mp4

Delete -> Save -> Still there but not editable -> Save And Quit -> Still there
Delete -> Save -> Without trying to edit it -> Save And Quit -> Still there
Delete -> Save And Quit -> Its deleted

@rishithreddy89
Copy link
Contributor Author

rishithreddy89 commented Feb 20, 2025

https://www.loom.com/share/91640e9632e8466e80f68927aab66fa5?sid=37cbef04-0795-4bc8-9601-9e2d8801126f
@Bastian2718 i could not find your bug it's working fine for me the event gets deleted when i delete and save it. Could you please check it out.

@rishithreddy89
Copy link
Contributor Author

rishithreddy89 commented Feb 20, 2025

@RCheesley and @andersonjeccel could you please verify whether you are facing an issue which @Bastian2718 mentioned and everything is working fine for me

@Bastian2718
Copy link

Bastian2718 commented Feb 21, 2025

@rishithreddy89 I checked again. My Issue only happens when the Trigger is already existing and I edit it.
Create Trigger -> Add Event -> delete Event -> it is deleted
Create Trigger -> Add Event -> Save -> delete Event -> save -> it is still there

@andersonjeccel
Copy link
Contributor

@Bastian2718 The behavior you're seeing is a different (unrelated) bug, thank you for flagging it!

@andersonjeccel
Copy link
Contributor

This PR can be merged

@nick-vanpraet nick-vanpraet merged commit 776b977 into mautic:5.2 Feb 21, 2025
17 checks passed
@nick-vanpraet nick-vanpraet changed the title Fixed: Delete Events for Point Triggers are weird #14412 Point Trigger edit and delete buttons are not visible #14412 Feb 21, 2025
@nick-vanpraet nick-vanpraet added the bug Issues or PR's relating to bugs label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs code-review-passed PRs which have passed code review points-scoring Anything related to points ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged regression A bug that broke something in the last release T1 Low difficulty to fix (issue) or test (PR) user-interface Anything related to appearance, layout, and interactivity user-testing-passed PRs which have been successfully tested by the required number of people.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants