Skip to content

Conversation

@andersonjeccel
Copy link
Contributor

No description provided.

@andersonjeccel andersonjeccel force-pushed the change-publish-to-available-for-fields branch from 8df337a to e2e195a Compare March 5, 2024 17:43
@RCheesley RCheesley marked this pull request as draft April 16, 2024 16:45
@andersonjeccel andersonjeccel changed the title Change publish to available for fields Change publish to available May 8, 2024
@andersonjeccel andersonjeccel marked this pull request as ready for review June 13, 2024 13:55
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some fixes, but also I think we have several pages where we should remove the enable/disable because we don't actually have that functionality in Mautic (yet) 😊 .

I'm guessing perhaps this came from some other docs, and the feature hasn't made it over yet, maybe? cc @escopecz who might be able to confirm?

.. vale off
**Publish at (date/time)** - This allows you to define the date and time at which this Dynamic Web Content item is available for displaying to Contacts
**Enable at (date/time)** - This allows you to define the date and time at which this Dynamic Web Content item is available for displaying to Contacts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Enable at (date/time)** - This allows you to define the date and time at which this Dynamic Web Content item is available for displaying to Contacts
**Enable at (date/time)** - This allows you to define the date and time at which this Dynamic Web Content item is available for displaying to Contacts

DWC doesn't actually have activate / deactivate date/times:

screenshot-mautic ddev site-2024 06 13-15_17_47

Maybe this is a feature we haven't yet got merged into core? cc @escopecz ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was just copy-pasted from other entity docs. I'm not aware of any PR that's adding it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s probably there for months 🤣

.. vale off
**Publish at (date/time)** - This allows you to define the date and time at which this Text Message is available for sending to Contacts
**Enable at (date/time)** - This allows you to define the date and time at which this Text Message is available for sending to Contacts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise the SMS bundle doesn't yet have the option to enable/disable, maybe an upcoming feature?
screenshot-mautic ddev site-2024 06 13-15_35_55

andersonjeccel and others added 7 commits June 14, 2024 08:09
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
@RCheesley
Copy link
Member

@andersonjeccel there's a few bits of feedback outstanding, and it might need updating given your more recent proposed changes, anyway?

@andersonjeccel
Copy link
Contributor Author

@RCheesley it'll happen, someday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants