Add support for custom management room messages #139
Conversation
| @@ -65,6 +65,9 @@ def do_update(self, helper: ConfigUpdateHelper) -> None: | |||
| copy("bridge.contact_list_names") | |||
| copy("bridge.displayname_preference") | |||
|
|
|||
| copy_dict("bridge.management_room_text") | |||
There was a problem hiding this comment.
The different messages should be copied individually because custom fields/messages aren't needed
| # Optional extra text sent when joining a management room. | ||
| # additional_help: | ||
| # plain: "This would be some additional text in case you need it." | ||
| # html: "This would be some additional <b>text</b> in case you need it." |
There was a problem hiding this comment.
Separate plaintext and HTML in the options doesn't seem particularly useful, it should just have a single string value for the markdown and render it at runtime (html = render(markdown) from mautrix.util.markdown). Alternatively it could have just the HTML field and un-render it (markdown = MatrixParser(html).text from mautrix.util.formatter)
| combined_plain = "" | ||
| combined_html = "" | ||
| for plain, html in welcome_messages: | ||
| combined_plain += plain + "\n" | ||
| combined_html += html + "<br/>" |
There was a problem hiding this comment.
"\n".join(...) would probably be nicer, I don't think it needs a trailing newline
|
@tulir Addressed your feedback and spun out into mautrix/python#58 Once that is reviewed I can close this and mautrix/telegram#674 and replace them with PRs adding only the new configuration. |
|
Superseded by #146 |
Adds configuration to support custom welcome messages in the management room.
Implementation is largely the same as mautrix/telegram#674