modules: un-modulify libsignalgo and signalmeow #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tulir
approved these changes
Dec 27, 2023
|
Oh right, this will break tests in CI because libsignalgo has a broken test right now. Also need to merge the two steps in actions (adding |
|
175fde6 should fix some of the broken tests, but |
I don't see any reason why they should have their own go.mod. I think this is legacy from when I had them in separate repositories. If we ever need to split those packages out into their own repo, we can just: 1. Copy the directories to a new repo 2. Copy the go.mod/go.sum files 3. Run `go mod tidy` in this repo and the new repo. This commit also removes the go.work and go.work.sum files. Signed-off-by: Sumner Evans <me@sumnerevans.com>
sumnerevans
force-pushed
the
fix-go-mod-tidy
branch
from
c3c90bd
to
6abe80e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't see any reason why they should have their own go.mod. I think
this is legacy from when I had them in separate repositories.
If we ever need to split those packages out into their own repo, we can
just:
go mod tidyin this repo and the new repo.This commit also removes the go.work and go.work.sum files.
Signed-off-by: Sumner Evans me@sumnerevans.com
Closes #398