-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add GitHub Actions workflow for tagging releases #6
Conversation
… main Provide additional guidance for developers on how to switch to the develop branch and ensure it is up-to-date with the main branch. This helps maintain consistency and reduces potential merge conflicts by keeping the develop branch synchronized with the latest changes from the main branch.
Create a new GitHub Actions workflow to automate the process of tagging releases. The workflow triggers on push, pull request, and manual dispatch events. It checks out the repository, installs dependencies, generates a build version, and builds the application. chore(package.json): remove redundant generate-version script from build command The `generate-version` script is now handled separately in the GitHub Actions workflow, making it unnecessary to include it in the local build command. This change streamlines the build process and ensures version generation is consistently managed by the CI pipeline.
Reviewer's Guide by SourceryThis PR implements a new GitHub Actions workflow for automated release tagging and simplifies the local build process. The workflow handles version generation and build steps in the CI pipeline, while the local build command has been streamlined by removing the redundant version generation step. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mauvehed - I've reviewed your changes - here's some feedback:
Overall Comments:
- The workflow triggers (push, pull_request, workflow_dispatch) seem too broad for a release tagging workflow. Consider limiting to specific events like
release
or tags if this is meant for releases. - Removing
generate-version
from the build script could cause issues with local builds. Consider adding a check in the build script to ensure version file exists or documenting the requirement to run generate-version first.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
ci(build-version.yml): add GitHub Actions workflow for tagging releases
Create a new GitHub Actions workflow to automate the process of tagging
releases. The workflow triggers on push, pull request, and manual
dispatch events. It checks out the repository, installs dependencies,
generates a build version, and builds the application.
chore(package.json): remove redundant generate-version script from build command
The
generate-version
script is now handled separately in the GitHubActions workflow, making it unnecessary to include it in the local
build command. This change streamlines the build process and ensures
version generation is consistently managed by the CI pipeline.
Summary by Sourcery
Implement a GitHub Actions workflow to automate release tagging and streamline the build process by removing the local 'generate-version' script. Update developer documentation to reflect changes in branch management.
CI:
Documentation:
Chores: