Guard the 'CustomSeverityConfigurable' tag with AnalysisLevel 9.0

Fixes dotnet#72094

Recently, as part of implementing support for dotnet#52991, we started respecting `option_name = option_value:severity` in build. As part of this change, if user has conflicting severity configurations from `option_name = option_value:severity` and `dotnet_diagnostic.IDExxxx.severity`, the former was given preference. We knew that this would likely break some customers, hence added functionality to guard this feature by enabling it only when AnalysisLevel was >= 9.0. However, that guard was only implemented for command line build path. This meant the feature was still being enabled by default in the IDE live analysis, which was unintentional. We now ensure that we respect the AnalysisLevel value even for this path and filter out CustomSeverityConfigurable custom tag for AnalysisLevel less than 9.

As part of this change, I also identified a bug in the SDK targets: https://github.com/dotnet/sdk/blob/3075c3bc8d8aa4e0ffcf2945459ef2ee383e3ae0/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.Analyzers.targets#L117-L120
We shouldn't be conditioning the inclusion of CodeStyle targets file on `EnforceCodeStyleInBuild` as we want the target to execute even for live analysis for IDE analyzers shipping inside VS, not only when enabled on build. Fix to remove that condition is required to ensure we thread in AnalysisLevel property value to the analyzers. I will create a PR for the same.

src/Analyzers/CSharp/Analyzers/AddAccessibilityModifiers/CSharpAddAccessibilityModifiersDiagnosticAnalyzer.cs

@@ -76,6 +76,7 @@ SyntaxKind.RecordDeclaration or
                 Descriptor,
                 name.GetLocation(),
                 option.Notification,
+                context.Options,
                 additionalLocations: additionalLocations,
                 modifiersAdded ? ModifiersAddedProperties : null));
         }

src/Analyzers/CSharp/Analyzers/AddBraces/CSharpAddBracesDiagnosticAnalyzer.cs

@@ -111,6 +111,7 @@ public void AnalyzeNode(SyntaxNodeAnalysisContext context)
                 Descriptor,
                 firstToken.GetLocation(),
                 option.Notification,
+                context.Options,
                 additionalLocations: null,
                 properties: null,
                 SyntaxFacts.GetText(firstToken.Kind())));

src/Analyzers/CSharp/Analyzers/ConvertNamespace/ConvertToBlockScopedNamespaceDiagnosticAnalyzer.cs

@@ -58,6 +58,7 @@ private void AnalyzeNamespace(SyntaxNodeAnalysisContext context)
                 this.Descriptor,
                 diagnosticLocation,
                 option.Notification,
+                context.Options,
                 ImmutableArray.Create(declaration.GetLocation()),
                 ImmutableDictionary<string, string?>.Empty);
         }

src/Analyzers/CSharp/Analyzers/ConvertNamespace/ConvertToFileScopedNamespaceDiagnosticAnalyzer.cs

@@ -61,6 +61,7 @@ private void AnalyzeNamespace(SyntaxNodeAnalysisContext context)
                 this.Descriptor,
                 diagnosticLocation,
                 option.Notification,
+                context.Options,
                 ImmutableArray.Create(declaration.GetLocation()),
                 ImmutableDictionary<string, string?>.Empty);
         }

src/Analyzers/CSharp/Analyzers/ConvertProgram/ConvertToProgramMainDiagnosticAnalyzer.cs

@@ -57,6 +57,7 @@ private void ProcessCompilationUnit(SyntaxNodeAnalysisContext context)
                 GetUseProgramMainDiagnosticLocation(
                     root, isHidden: severity.WithDefaultSeverity(DiagnosticSeverity.Hidden) == ReportDiagnostic.Hidden),
                 option.Notification,
+                context.Options,
                 [],
                 ImmutableDictionary<string, string?>.Empty));
         }

src/Analyzers/CSharp/Analyzers/ConvertProgram/ConvertToTopLevelStatementsDiagnosticAnalyzer.cs

@@ -77,6 +77,7 @@ private void ProcessCompilationUnit(SyntaxNodeAnalysisContext context)
                             GetUseTopLevelStatementsDiagnosticLocation(
                                 methodDeclaration, isHidden: option.Notification.Severity.WithDefaultSeverity(DiagnosticSeverity.Hidden) == ReportDiagnostic.Hidden),
                             option.Notification,
+                            context.Options,
                             ImmutableArray.Create(methodDeclaration.GetLocation()),
                             ImmutableDictionary<string, string?>.Empty));
                     }

src/Analyzers/CSharp/Analyzers/ConvertSwitchStatementToExpression/ConvertSwitchStatementToExpressionDiagnosticAnalyzer.cs

@@ -70,6 +70,7 @@ private void AnalyzeSyntax(SyntaxNodeAnalysisContext context)
                 // Report the diagnostic on the "switch" keyword.
                 location: switchStatement.GetFirstToken().GetLocation(),
                 notificationOption: styleOption.Notification,
+                context.Options,
                 additionalLocations: additionalLocations.ToArrayAndFree(),
                 properties: ImmutableDictionary<string, string?>.Empty
                     .Add(Constants.NodeToGenerateKey, ((int)nodeToGenerate).ToString(CultureInfo.InvariantCulture))

src/Analyzers/CSharp/Analyzers/InlineDeclaration/CSharpInlineDeclarationDiagnosticAnalyzer.cs

@@ -246,6 +246,7 @@ private void AnalyzeSyntaxNode(SyntaxNodeAnalysisContext context, INamedTypeSymb
                 Descriptor,
                 reportNode.GetLocation(),
                 option.Notification,
+                context.Options,
                 additionalLocations: allLocations,
                 properties: null));
         }

src/Analyzers/CSharp/Analyzers/InvokeDelegateWithConditionalAccess/InvokeDelegateWithConditionalAccessAnalyzer.cs

@@ -184,6 +184,7 @@ private void ReportDiagnostics(
                 Descriptor,
                 fadeLocation,
                 NotificationOption2.ForSeverity(Descriptor.DefaultSeverity),
+                syntaxContext.Options,
                 additionalLocations,
                 additionalUnnecessaryLocations: [fadeLocation],
                 properties));
@@ -193,6 +194,7 @@ private void ReportDiagnostics(
                 Descriptor,
                 expressionStatement.GetLocation(),
                 notificationOption,
+                syntaxContext.Options,
                 additionalLocations, properties));
 
             // If the if-statement extends past the expression statement, then fade out the rest.
@@ -203,6 +205,7 @@ private void ReportDiagnostics(
                     Descriptor,
                     fadeLocation,
                     NotificationOption2.ForSeverity(Descriptor.DefaultSeverity),
+                    syntaxContext.Options,
                     additionalLocations,
                     additionalUnnecessaryLocations: [fadeLocation],
                     properties));

src/Analyzers/CSharp/Analyzers/MakeLocalFunctionStatic/MakeLocalFunctionStaticDiagnosticAnalyzer.cs

@@ -54,6 +54,7 @@ private void AnalyzeSyntax(SyntaxNodeAnalysisContext context)
                     Descriptor,
                     localFunction.Identifier.GetLocation(),
                     option.Notification,
+                    context.Options,
                     additionalLocations: ImmutableArray.Create(localFunction.GetLocation()),
                     properties: null));
             }

src/Analyzers/CSharp/Analyzers/MakeStructMemberReadOnly/CSharpMakeStructMemberReadOnlyAnalyzer.cs

@@ -162,6 +162,7 @@ private void AnalyzeBlock(
                 Descriptor,
                 location,
                 notificationOption,
+                context.Options,
                 additionalLocations: ImmutableArray.Create(additionalLocation),
                 properties: null);
         }

src/Analyzers/CSharp/Analyzers/MakeStructReadOnly/CSharpMakeStructReadOnlyDiagnosticAnalyzer.cs

@@ -61,6 +61,7 @@ protected override void InitializeWorker(AnalysisContext context)
                         Descriptor,
                         location,
                         option.Notification,
+                        context.Options,
                         additionalLocations: ImmutableArray.Create(additionalLocation),
                         properties: null));
                 });

src/Analyzers/CSharp/Analyzers/MisplacedUsingDirectives/MisplacedUsingDirectivesDiagnosticAnalyzer.cs

@@ -106,6 +106,7 @@ private static void ReportDiagnostics(
                     descriptor,
                     usingDirective.GetLocation(),
                     option.Notification,
+                    context.Options,
                     additionalLocations: null,
                     properties: null));
             }

src/Analyzers/CSharp/Analyzers/NewLines/ArrowExpressionClausePlacement/ArrowExpressionClausePlacementDiagnosticAnalyzer.cs

@@ -78,6 +78,7 @@ private void ProcessArrowExpressionClause(
                 this.Descriptor,
                 arrowExpressionClause.ArrowToken.GetLocation(),
                 notificationOption,
+                context.Options,
                 additionalLocations: null,
                 properties: null));
 

src/Analyzers/CSharp/Analyzers/NewLines/ConditionalExpressionPlacement/ConditionalExpressionPlacementDiagnosticAnalyzer.cs

@@ -60,6 +60,7 @@ private void ProcessConditionalExpression(SyntaxNodeAnalysisContext context)
             this.Descriptor,
             conditionalExpression.QuestionToken.GetLocation(),
             option.Notification,
+            context.Options,
             additionalLocations: null,
             properties: null));
 

src/Analyzers/CSharp/Analyzers/NewLines/ConsecutiveBracePlacement/ConsecutiveBracePlacementDiagnosticAnalyzer.cs

@@ -84,6 +84,7 @@ private void ProcessToken(SyntaxTreeAnalysisContext context, NotificationOption2
                 this.Descriptor,
                 secondBrace.GetLocation(),
                 notificationOption,
+                context.Options,
                 additionalLocations: null,
                 properties: null));
         }

src/Analyzers/CSharp/Analyzers/NewLines/ConstructorInitializerPlacement/ConstructorInitializerPlacementDiagnosticAnalyzer.cs

@@ -92,6 +92,7 @@ private void ProcessConstructorInitializer(
                 this.Descriptor,
                 colonToken.GetLocation(),
                 notificationOption,
+                context.Options,
                 additionalLocations: ImmutableArray.Create(initializer.GetLocation()),
                 properties: null));
         }

src/Analyzers/CSharp/Analyzers/NewLines/EmbeddedStatementPlacement/EmbeddedStatementPlacementDiagnosticAnalyzer.cs

@@ -78,6 +78,7 @@ private bool CheckStatementSyntax(SyntaxTreeAnalysisContext context, Notificatio
                 this.Descriptor,
                 statement.GetFirstToken().GetLocation(),
                 notificationOption,
+                context.Options,
                 additionalLocations,
                 properties: null));
             return true;

src/Analyzers/CSharp/Analyzers/RemoveConfusingSuppression/CSharpRemoveConfusingSuppressionDiagnosticAnalyzer.cs

@@ -44,6 +44,7 @@ private void AnalyzeSyntax(SyntaxNodeAnalysisContext context)
                 Descriptor,
                 ((PostfixUnaryExpressionSyntax)left).OperatorToken.GetLocation(),
                 NotificationOption2.Warning,
+                context.Options,
                 ImmutableArray.Create(node.GetLocation()),
                 properties: null));
         }

src/Analyzers/CSharp/Analyzers/RemoveUnnecessaryLambdaExpression/CSharpRemoveUnnecessaryLambdaExpressionDiagnosticAnalyzer.cs

@@ -232,6 +232,7 @@ private void AnalyzeSyntax(SyntaxNodeAnalysisContext context, INamedTypeSymbol?
                 Descriptor,
                 syntaxTree.GetLocation(startReportSpan),
                 preference.Notification,
+                context.Options,
                 additionalLocations: [anonymousFunction.GetLocation()],
                 additionalUnnecessaryLocations: [syntaxTree.GetLocation(startReportSpan), syntaxTree.GetLocation(endReportSpan)]));
         }

src/Analyzers/CSharp/Analyzers/RemoveUnreachableCode/CSharpRemoveUnreachableCodeDiagnosticAnalyzer.cs

@@ -124,6 +124,7 @@ private void ProcessUnreachableDiagnostic(
             Descriptor,
             firstStatementLocation,
             NotificationOption2.ForSeverity(Descriptor.DefaultSeverity),
+            context.Options,
             additionalLocations: [],
             additionalUnnecessaryLocations: additionalLocations));
 
@@ -142,6 +143,7 @@ private void ProcessUnreachableDiagnostic(
                 Descriptor,
                 location,
                 NotificationOption2.ForSeverity(Descriptor.DefaultSeverity),
+                context.Options,
                 additionalLocations,
                 additionalUnnecessaryLocations,
                 s_subsequentSectionProperties));

src/Analyzers/CSharp/Analyzers/SimplifyPropertyPattern/CSharpSimplifyPropertyPatternDiagnosticAnalyzer.cs

@@ -66,6 +66,7 @@ private void AnalyzeSubpattern(SyntaxNodeAnalysisContext syntaxContext)
                 Descriptor,
                 expressionColon.GetLocation(),
                 styleOption.Notification,
+                syntaxContext.Options,
                 ImmutableArray.Create(subpattern.GetLocation()),
                 properties: null));
         }

src/Analyzers/CSharp/Analyzers/UseCollectionExpression/CSharpUseCollectionExpressionForArrayDiagnosticAnalyzer.cs

@@ -191,6 +191,7 @@ private void AnalyzeArrayInitializerExpression(SyntaxNodeAnalysisContext context
                 Descriptor,
                 initializer.OpenBraceToken.GetLocation(),
                 option.Notification,
+                context.Options,
                 additionalLocations: ImmutableArray.Create(initializer.GetLocation()),
                 properties: changesSemantics ? ChangesSemantics : null));
         }
@@ -205,6 +206,7 @@ private void ReportArrayCreationDiagnostics(
             Descriptor,
             expression.GetFirstToken().GetLocation(),
             notification,
+            context.Options,
             additionalLocations: locations,
             properties: properties));
 
@@ -219,6 +221,7 @@ expression is ArrayCreationExpressionSyntax arrayCreationExpression
             UnnecessaryCodeDescriptor,
             additionalUnnecessaryLocations[0],
             NotificationOption2.ForSeverity(UnnecessaryCodeDescriptor.DefaultSeverity),
+            context.Options,
             additionalLocations: locations,
             additionalUnnecessaryLocations: additionalUnnecessaryLocations,
             properties: properties));

src/Analyzers/CSharp/Analyzers/UseCollectionExpression/CSharpUseCollectionExpressionForBuilderDiagnosticAnalyzer.cs

@@ -54,6 +54,7 @@ private void AnalyzeInvocationExpression(
             Descriptor,
             analysisResult.DiagnosticLocation,
             option.Notification,
+            context.Options,
             additionalLocations: locations,
             properties: properties));
 
@@ -70,6 +71,7 @@ void FadeOutCode(SyntaxNodeAnalysisContext context, AnalysisResult analysisResul
                 UnnecessaryCodeDescriptor,
                 additionalUnnecessaryLocations[0],
                 NotificationOption2.ForSeverity(UnnecessaryCodeDescriptor.DefaultSeverity),
+                context.Options,
                 additionalLocations: locations,
                 additionalUnnecessaryLocations: additionalUnnecessaryLocations,
                 properties: properties));
@@ -87,6 +89,7 @@ void FadeOutCode(SyntaxNodeAnalysisContext context, AnalysisResult analysisResul
                     UnnecessaryCodeDescriptor,
                     additionalUnnecessaryLocations[0],
                     NotificationOption2.ForSeverity(UnnecessaryCodeDescriptor.DefaultSeverity),
+                    context.Options,
                     additionalLocations: locations,
                     additionalUnnecessaryLocations: additionalUnnecessaryLocations,
                     properties: properties));

src/Analyzers/CSharp/Analyzers/UseCollectionExpression/CSharpUseCollectionExpressionForCreateDiagnosticAnalyzer.cs

@@ -60,6 +60,7 @@ private void AnalyzeInvocationExpression(SyntaxNodeAnalysisContext context, INam
             Descriptor,
             memberAccess.Name.Identifier.GetLocation(),
             option.Notification,
+            context.Options,
             additionalLocations: locations,
             properties));
 
@@ -73,6 +74,7 @@ private void AnalyzeInvocationExpression(SyntaxNodeAnalysisContext context, INam
             UnnecessaryCodeDescriptor,
             additionalUnnecessaryLocations[0],
             NotificationOption2.ForSeverity(UnnecessaryCodeDescriptor.DefaultSeverity),
+            context.Options,
             additionalLocations: locations,
             additionalUnnecessaryLocations: additionalUnnecessaryLocations,
             properties));

src/Analyzers/CSharp/Analyzers/UseCollectionExpression/CSharpUseCollectionExpressionForEmptyDiagnosticAnalyzer.cs

@@ -56,6 +56,7 @@ private void AnalyzeMemberAccess(SyntaxNodeAnalysisContext context, INamedTypeSy
             Descriptor,
             memberAccess.Name.Identifier.GetLocation(),
             option.Notification,
+            context.Options,
             additionalLocations: ImmutableArray.Create(nodeToReplace.GetLocation()),
             properties: changesSemantics ? ChangesSemantics : null));
     }

src/Analyzers/CSharp/Analyzers/UseCollectionExpression/CSharpUseCollectionExpressionForFluentDiagnosticAnalyzer.cs

@@ -110,6 +110,7 @@ private void AnalyzeMemberAccess(SyntaxNodeAnalysisContext context, INamedTypeSy
             Descriptor,
             memberAccess.Name.Identifier.GetLocation(),
             option.Notification,
+            context.Options,
             additionalLocations: ImmutableArray.Create(invocation.GetLocation()),
             properties: analysisResult.Value.ChangesSemantics ? ChangesSemantics : null));
 

src/Analyzers/CSharp/Analyzers/UseCollectionExpression/CSharpUseCollectionExpressionForStackAllocDiagnosticAnalyzer.cs

@@ -59,6 +59,7 @@ private void AnalyzeImplicitStackAllocExpression(SyntaxNodeAnalysisContext conte
             Descriptor,
             expression.GetFirstToken().GetLocation(),
             option.Notification,
+            context.Options,
             additionalLocations: locations,
             properties: null));
 
@@ -71,6 +72,7 @@ private void AnalyzeImplicitStackAllocExpression(SyntaxNodeAnalysisContext conte
             UnnecessaryCodeDescriptor,
             additionalUnnecessaryLocations[0],
             NotificationOption2.ForSeverity(UnnecessaryCodeDescriptor.DefaultSeverity),
+            context.Options,
             additionalLocations: locations,
             additionalUnnecessaryLocations: additionalUnnecessaryLocations));
     }
@@ -97,6 +99,7 @@ private void AnalyzeExplicitStackAllocExpression(SyntaxNodeAnalysisContext conte
             Descriptor,
             expression.GetFirstToken().GetLocation(),
             option.Notification,
+            context.Options,
             additionalLocations: locations,
             properties: null));
 
@@ -109,6 +112,7 @@ private void AnalyzeExplicitStackAllocExpression(SyntaxNodeAnalysisContext conte
             UnnecessaryCodeDescriptor,
             additionalUnnecessaryLocations[0],
             NotificationOption2.ForSeverity(UnnecessaryCodeDescriptor.DefaultSeverity),
+            context.Options,
             additionalLocations: locations,
             additionalUnnecessaryLocations: additionalUnnecessaryLocations));
     }

src/Analyzers/CSharp/Analyzers/UseCompoundAssignment/CSharpUseCompoundCoalesceAssignmentDiagnosticAnalyzer.cs

@@ -96,6 +96,7 @@ private void AnalyzeCoalesceExpression(SyntaxNodeAnalysisContext context)
                 Descriptor,
                 coalesceExpression.OperatorToken.GetLocation(),
                 option.Notification,
+                context.Options,
                 additionalLocations: ImmutableArray.Create(coalesceExpression.GetLocation()),
                 properties: null));
         }
@@ -168,6 +169,7 @@ private void AnalyzeIfStatement(SyntaxNodeAnalysisContext context)
                 Descriptor,
                 ifStatement.IfKeyword.GetLocation(),
                 option.Notification,
+                context.Options,
                 additionalLocations: ImmutableArray.Create(ifStatement.GetLocation()),
                 properties: null));
         }

src/Analyzers/CSharp/Analyzers/UseDeconstruction/CSharpUseDeconstructionDiagnosticAnalyzer.cs

@@ -66,6 +66,7 @@ private void AnalyzeVariableDeclaration(
                 Descriptor,
                 variableDeclaration.Variables[0].Identifier.GetLocation(),
                 notificationOption,
+                context.Options,
                 additionalLocations: null,
                 properties: null));
         }
@@ -80,6 +81,7 @@ private void AnalyzeForEachStatement(
                 Descriptor,
                 forEachStatement.Identifier.GetLocation(),
                 notificationOption,
+                context.Options,
                 additionalLocations: null,
                 properties: null));
         }

src/Analyzers/CSharp/Analyzers/UseDefaultLiteral/CSharpUseDefaultLiteralDiagnosticAnalyzer.cs

@@ -52,6 +52,7 @@ private void AnalyzeSyntax(SyntaxNodeAnalysisContext context)
                     Descriptor,
                     defaultExpression.GetLocation(),
                     preference.Notification,
+                    context.Options,
                     additionalLocations: [],
                     additionalUnnecessaryLocations: [defaultExpression.SyntaxTree.GetLocation(fadeSpan)]));
         }

src/Analyzers/CSharp/Analyzers/UseExpressionBody/UseExpressionBodyDiagnosticAnalyzer.cs

@@ -106,7 +106,7 @@ private void AnalyzeSyntax(SyntaxNodeAnalysisContext context)
                 var properties = ImmutableDictionary<string, string?>.Empty.Add(nameof(UseExpressionBody), "");
                 return DiagnosticHelper.Create(
                     CreateDescriptorWithId(helper.DiagnosticId, helper.EnforceOnBuild, hasAnyCodeStyleOption: true, helper.UseExpressionBodyTitle, helper.UseExpressionBodyTitle),
-                    location, preference.Notification, additionalLocations: additionalLocations, properties: properties);
+                    location, preference.Notification, context.Options, additionalLocations: additionalLocations, properties: properties);
             }
 
             if (helper.CanOfferUseBlockBody(preference, declaration, forAnalyzer: true, out var fixesError, out var expressionBody))
@@ -124,7 +124,7 @@ private void AnalyzeSyntax(SyntaxNodeAnalysisContext context)
                 var additionalLocations = ImmutableArray.Create(declaration.GetLocation());
                 return DiagnosticHelper.Create(
                     CreateDescriptorWithId(helper.DiagnosticId, helper.EnforceOnBuild, hasAnyCodeStyleOption: true, helper.UseBlockBodyTitle, helper.UseBlockBodyTitle),
-                    location, preference.Notification, additionalLocations: additionalLocations, properties: properties);
+                    location, preference.Notification, context.Options, additionalLocations: additionalLocations, properties: properties);
             }
 
             return null;