Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added download function for geofence and rallypoints #353

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

mattes-bru
Copy link
Contributor

No description provided.

Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggestions. The naming must be consistent, otherwise the auto-generation won't work. Best to test it before making the PR.

However, you probably can re-use the actual mission items in the requests, e.g.:

message DownloadGeofenceRequest {}
message DownloadGeofenceResponse {
    MissionRawResult mission_raw_result = 1;
    repeated MissionItem geofence_items = 2; // The geofence items
}

protos/mission_raw/mission_raw.proto Outdated Show resolved Hide resolved
protos/mission_raw/mission_raw.proto Outdated Show resolved Hide resolved
protos/mission_raw/mission_raw.proto Outdated Show resolved Hide resolved
protos/mission_raw/mission_raw.proto Outdated Show resolved Hide resolved
@mattes-bru
Copy link
Contributor Author

Sorry, I was too fast on the PR button. I updated naming & comments

@julianoes julianoes merged commit 4b3ff32 into mavlink:main Sep 30, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants