Update configuration files in launch directory #1916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed '/**' in namespace/node_name of parameters in configuration
files that located under ./mavros/launch/ directory
This commit modifies the configuration files in the launch directory of the MAVROS package.
The '/**' in namespace/node_name of parameters were removed to ensure proper configuration.
The specific changes were made in thes files:
./mavros/launch/apm_config.yaml
./mavros/launch/apm_pluginlists.yaml
./mavros/launch/px4_config.yaml
./mavros/launch/px4_pluginlists.yaml
|
this PR related to #1912 issue |
|
Please try approach from #1915 |
this approach didn't work for me, all parameters still take default values |
|
Strange. Soryr, what ros2 release you're on? |
|
@vooon Foxy release because I'm using ubunut20, but I looked at the documentation for both the Foxy and Humble release about parameters as they have the same documentation so I don't know if the issue is related to the Ros2 distribution I'm using |
|
@hasanosman601 that's unclear, but some features changes quite hard comparing to older releases. |
|
@vooon ok, I'll keep this change since it works for me on Foxy release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed '/**' in namespace/node_name of parameters in configuration files that located under ./mavros/launch/ directory
This commit modifies the configuration files in the launch directory of the MAVROS package. The '/**' in namespace/node_name of parameters were removed to ensure proper configuration. The specific changes were made in these files:
./mavros/launch/apm_config.yaml
./mavros/launch/apm_pluginlists.yaml
./mavros/launch/px4_config.yaml
./mavros/launch/px4_pluginlists.yaml