add release tag to metainfo file #10653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickelectric
requested changes
Apr 7, 2023
|
https://github.com/mavlink/qgroundcontrol/blob/master/CMakeLists.txt#L48
https://github.com/mavlink/qgroundcontrol/blob/master/QGCCommon.pri#L165
…On Fri, Apr 7, 2023, 17:50 Christian Rauch ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In deploy/org.mavlink.qgroundcontrol.metainfo.xml
<#10653 (comment)>
:
> @@ -24,6 +24,10 @@
<content_rating type="oars-1.1" />
+ <releases>
+ <release date="2023-03-21" version="4.2.6"/>
Can you give me a pointer where the release version is extracted during CI?
—
Reply to this email directly, view it on GitHub
<#10653 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJIYCMJFZUOYHWAP3FBFTLXAB4YTANCNFSM6AAAAAAWVXFH7Q>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
The automatic release tag creation passes the Flathub CI: https://buildbot.flathub.org/#/builders/33/builds/4165. Thanks for the feedback. |
|
Is this ready to go? |
From my side yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
releasetag to the.metainfo.xml.According to the documentation, this is only suggested. But it is required for Flathub and would allow using the upstream metainfo file without modifications.