Comms: Prepare SerialLink for Threading Changes #11745
Draft
+313
−385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTRamsey
force-pushed
the
dev-serial-link
branch
4 times, most recently
from
5e9ff36
to
09670ca
Compare
HTRamsey
force-pushed
the
dev-serial-link
branch
2 times, most recently
from
5aa4763
to
f0cd16c
Compare
HTRamsey
force-pushed
the
dev-serial-link
branch
6 times, most recently
from
2c8fedb
to
406f9cc
Compare
HTRamsey
commented
Sep 12, 2024
src/Comms/LinkManager.cc
Outdated
| @@ -257,11 +259,6 @@ void LinkManager::setConnectionsSuspended(QString reason) | |||
| _connectionsSuspendedReason = reason; | |||
| } | |||
|
|
|||
| void LinkManager::suspendConfigurationUpdates(bool suspend) | |||
There was a problem hiding this comment.
FYI this was never used anywhere and I don't see a significant need for it
HTRamsey
force-pushed
the
dev-serial-link
branch
from
406f9cc
to
b0ca2b0
Compare
HTRamsey
changed the title
HTRamsey
force-pushed
the
dev-serial-link
branch
2 times, most recently
from
5607987
to
52ace88
Compare
HTRamsey
force-pushed
the
dev-serial-link
branch
from
52ace88
to
02ca9a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #11598
fixes #11849
The QThread inheritance will have to be removed after the remaining links are fixed
Tested by turning all streams to 100Hz and letting it run for a while: