Terrain: Cleanup Terrain Queries

[HTRamsey]

Clean up and better structure Terrain files in prep for #11795
Fixes some QObject parenting
Finishes setting up unit tests

[DonLakeFlyer]

Are you running some sort of lint thing on stuff before you checkin? Removing tabs and moving around the foo* bar to foo *bar generates all sorts of unnecessary diffs in the commit.

[HTRamsey]

I don't but it would be really nice to get everything standardized because with so many different contributors things have gotten to be a mess so I wanted to do it right and clean when I work on things. But yeah I get the git diffs part which is why I try to add unit tests to everything I do to help verify changes. I don't think a formatter should be run on everything at once, but rather only do it on one thing at a time that's been verified through testing.

However with these files it's a bit different because they have to change drastically anyways to cleanly implement different providers.

[DonLakeFlyer]

I don't but it would be really nice to get everything standardized because with so many different contributors things have gotten to be a mess so I wanted to do it right and clean when I work on things.

Ok, all good then. I'll change to be closer to what most people like.

[DonLakeFlyer]

Are you going to pull out the old AirMap stuff in separate pull?

[HTRamsey]

Are you going to pull out the old AirMap stuff in separate pull?

That or convert it to Copernicus if I can. Not sure why some stuff was converted to Copernicus but not everything.