Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: Update the macro register after each keypress #1277

Closed
wants to merge 1 commit into from

Conversation

lenormf
Copy link
Contributor

@lenormf lenormf commented Mar 14, 2017

No description provided.

@mawww
Copy link
Owner

mawww commented Mar 14, 2017

Whats the goal there ? If its for displaying the keys being recorded, I think a hard coded behaviour in generate_context_info showing the keys in recording (<reg>=<keys>...) would be good enough.

@lenormf
Copy link
Contributor Author

lenormf commented Mar 14, 2017

I don't care much for the issue, having the register up-to-date at any point in time makes more sense if it doesn't introduce new issues.

@mawww
Copy link
Owner

mawww commented May 10, 2017

We are recording, it seems to make as much sense to consider the register should be updated once we finish recording than update it on the go. This is why I wonder if we have a use case for that feature, or if some behaviour gets better once we do that.

@lenormf
Copy link
Contributor Author

lenormf commented May 12, 2017

One possible case would be the issue linked to this PR, I don't have any personal motivation to have that merged otherwise.

@mawww
Copy link
Owner

mawww commented Jun 17, 2017

Reopen if we have a proper reason to do that, for now lets keep things simple.

@mawww mawww closed this Jun 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants