Avoid hiding files in /mnt when extracting images #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktetzlaff
force-pushed
the
kt-dont-overwrite-mnt-on-qnap
branch
from
cbb5d63
to
55a02ce
Compare
When running extract_qnap_fw.sh on a QNAP NAS, mounting something on /mnt hides already existing mounts within /mnt. A lot of file in /etc are actually just symlinks to /mnt/config, and /etc/passwd is one of them. So when mounting a directory on /mnt results in loosing access to all account information. I.e. any subsequent attempt to use sudo (or to login to the system) fails. This change uses temporary directories (created using 'mktemp') to mount images in order to avoid the issue.
ktetzlaff
force-pushed
the
kt-dont-overwrite-mnt-on-qnap
branch
from
55a02ce
to
f5e7d18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
extract_qnap_fw.shon a QNAP NAS, mounting something on/mnthides already existing mounts within/mnt. A lot of file in/etcare actually just symlinks to/mnt/config, and/etc/passwdis one of them. So when mounting a directory on/mntresults in loosing access to all account information. I.e. any subsequent attempt to use sudo (or login to the system) fails.This change uses temporary directories (created using
mktemp) to mount images in order to avoid the issue.