Updated a couple of solutions to use newer ways to instantiate node buffers #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eprecated way to make buffers so people trying to learn about this stuff aren't given a deprecate example as a good solution.
…ecated way of making a new node buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the solutions to a couple of the exercises to use the non-deprecated way to create node buffers. It is kind of confusing because you do still use like
In a browser but in the node docs say to use Buffer.from(stufftomakebuffer) or Buffer.alloc(size) to make new buffers. Though using new Buffer should work for the for a while yet. Maybe both kinds of solutions should be shown because new Buffer() is used a lot?
see: https://nodejs.org/api/buffer.html#buffer_class_method_buffer_from_buffer