-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use mkdirp 0.5.1 #66
use mkdirp 0.5.1 #66
Conversation
there is a bug in mkdirp 0.5.0 that rollup can't parse (rollup/rollup#361)
merging this pr should fix #57 |
and should also fix a bug in This makes storyshots tests with jest + storybook + storyshots fail |
This is breaking all jest snapshot tests for storybook, pls merge. |
I just also noticed this same issue when using Puppeteer with Jest snapshot (to capture JSON output of a page) |
@maxogden Do you need help? Perhaps someone in here is willing to help you maintain this package? |
Yes would anyone like to maintain this? Let me know your npm and github username |
Please merge this one asap! =) |
is that fix merged already? |
@erez-guesty No, the pull request state above says still OPEN! ;) |
|
@maxogden how do I send a message to you? |
thanks @malept |
there is a bug in mkdirp 0.5.0 that rollup can't parse (rollup/rollup#361)
Fixes #57.