Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use mkdirp 0.5.1 #66

Merged
merged 1 commit into from
May 24, 2018
Merged

use mkdirp 0.5.1 #66

merged 1 commit into from
May 24, 2018

Conversation

tcoopman
Copy link
Contributor

@tcoopman tcoopman commented Mar 17, 2018

there is a bug in mkdirp 0.5.0 that rollup can't parse (rollup/rollup#361)

Fixes #57.

there is a bug in mkdirp 0.5.0 that rollup can't parse (rollup/rollup#361)
@fczuardi
Copy link

fczuardi commented Apr 6, 2018

merging this pr should fix #57

@fczuardi
Copy link

fczuardi commented Apr 6, 2018

and should also fix a bug in @storybook/addon-storyshots that depends on puppeteer that depends on extract-zip

This makes storyshots tests with jest + storybook + storyshots fail

@jonathanong
Copy link

@malept

@jnrepo
Copy link

jnrepo commented Apr 8, 2018

This is breaking all jest snapshot tests for storybook, pls merge.

@justinmwarner
Copy link

justinmwarner commented Apr 18, 2018

Can we get this merged in? As @jnrepo mentioned, this is breaking storybook storyshots. @maxogden

@StephanBijzitter
Copy link

I just also noticed this same issue when using Puppeteer with Jest snapshot (to capture JSON output of a page)

@ndelangen
Copy link

ndelangen commented May 1, 2018

@maxogden Do you need help? Perhaps someone in here is willing to help you maintain this package?

@max-mapper
Copy link
Owner

Yes would anyone like to maintain this? Let me know your npm and github username

@MartinLoeper
Copy link

Please merge this one asap! =)

@erez-guesty
Copy link

is that fix merged already?

@MartinLoeper
Copy link

@erez-guesty No, the pull request state above says still OPEN! ;)

@ndelangen
Copy link

would anyone like to maintain this? Let me know your npm and github username

@jnrepo
Copy link

jnrepo commented May 20, 2018

@maxogden how do I send a message to you?

@max-mapper
Copy link
Owner

@jnrepo you can email me or the other maintainer @malept or leave a message here

@malept
Copy link
Collaborator

malept commented May 24, 2018

Thanks for your patience. I'll merge this shortly (plus fix #70) and make a new release.

I've added a new issue #71 to reflect that the module needs new maintainers. Please comment there if you'd like to help with more timely fixes.

@malept malept merged commit c1aa196 into max-mapper:master May 24, 2018
@max-mapper
Copy link
Owner

thanks @malept

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.