Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: calling showWindow() prevents menubar window from closing #287

Merged
merged 1 commit into from
May 28, 2020

Conversation

quanglam2807
Copy link
Contributor

This PR fixes the following bug:

Bug Description:

this._isVisible is only set to true in clicked() so if showWindow() is called directly, this._isVisible is not updated and prevents closeWindow() to work properly.

Step to Reproduce:

const { menubar } = require('menubar');

const mb = menubar();

mb.on('ready', () => {
  mb.showWindow();
});

The menubar window will show up but clicking outside would not close the window.

Copy link
Collaborator

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, makes sense. Thanks a lot!

@amaury1093 amaury1093 merged commit 53d8f82 into max-mapper:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants