Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Star-range reset when selecting a new language #223

Closed
amandee27 opened this issue Oct 9, 2024 · 3 comments · Fixed by #226
Closed

Star-range reset when selecting a new language #223

amandee27 opened this issue Oct 9, 2024 · 3 comments · Fixed by #226
Assignees

Comments

@amandee27
Copy link

Let’s say we selected a language and entered a star range to filter repos. Now if we want to find the projects between the same star range but with a different language, we have to select the language and re-enter the same star range. Because when we choose a new language, the star range reset to the initial state. I think it would be a better user experience if we could select another language without resetting the star range. The same issue happens with the sorting field as well.


179 REPOSITORIES
Image 1: Search results for the javascript projects between 500-1000 stars


179 REPOSITORIES
Image 2: Trying to find the python projects in the same star range(500-1000) by selecting the language


7708 REPOSITORIES
Image 3: The star range field got reset after selecting the language as python

@amandee27
Copy link
Author

Happy to contribute and implement this if you think this is a good feature to have @max-programming

@max-programming
Copy link
Owner

This is definitely a very good improvement!

Thanks for the issue and yes open a pr when ready ✌️

@amandee27
Copy link
Author

Thanks ! Will open a PR within 1-2 days.

amandee27 pushed a commit to amandee27/hacktoberfest-projects that referenced this issue Oct 12, 2024
amandee27 pushed a commit to amandee27/hacktoberfest-projects that referenced this issue Oct 12, 2024
amandee27 pushed a commit to amandee27/hacktoberfest-projects that referenced this issue Oct 16, 2024
max-programming added a commit that referenced this issue Oct 16, 2024
…et-2

Fix #223 prevent resetting star range and sort order when selecting a language
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment