Skip to content

Pagination does not reset when updating search params #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amandee27 opened this issue Oct 17, 2024 · 2 comments · Fixed by #230
Closed

Pagination does not reset when updating search params #228

amandee27 opened this issue Oct 17, 2024 · 2 comments · Fixed by #230
Assignees

Comments

@amandee27
Copy link

The pagination does not reset to the first page after we select a new language, star range, or sorting (e.g., Best match). Ideally, it should show the first page after the search query changes.

Steps Reproduce

  1. Select 'C' as the language
  2. Set the star range from 0 to 20000 and search
  3. Now go to the next page (ie: 2nd page)
  4. Then update the star range from 10000 to 20000 and search

Observation: Page not found error
Expected: We should show the first page for the 'C' language with the star range from 10000 to 20000 (which only has 1 page)

@amandee27
Copy link
Author

I'm already working on a fix for this.

amandee27 pushed a commit to amandee27/hacktoberfest-projects that referenced this issue Oct 18, 2024
@max-programming
Copy link
Owner

Thanks for pointing it out and working on it ✌️

max-programming added a commit that referenced this issue Oct 30, 2024
Fix #228 pagination does not reset when updating search params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants