fixed #214 removed height property from cards to make responsive #216
Conversation
|
@love-sonkar is attempting to deploy a commit to the Max Programming's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks for submitting this fix! Would you be interested in addressing some other responsive issues I mentioned below?
|
package-lock.json
Outdated
There was a problem hiding this comment.
Can you delete the package lockfile please?
As this project uses pnpm
i have deleted package-lock.json
|
i'll start working on the new issues. |
|
i have fixed the issue, i'm not able to reproduce this issue other than that i have fixed all issue as you mentions.
|
|
@love-sonkar The second image you shared is not a problem so ignore that The sort and language buttons look fine but the header feels too cluttered |
|
we can do one thing, we can remove the contributers button from header when we go 768px |
|
i have given hidden property to the contributers button and added text wrap to sign in text.
|
|
@love-sonkar How about having a hamburger menu instead for mobile? We can use drawer component by DaisyUI |
|
Hey i would like to suggest somthing. so our website is all about finding repository for hacktoberfest and i think most of the users visit this site in laptop desktop, so i don't think it's good idea to add an drawer component because our our visitors are all from laptop and desktop. |
|
@love-sonkar Even though most visitors use laptop/desktop, there is still a large number of users on phones, and it will increase.
|
|
okay i will create new Issue because i'm little bit busy so i can't implement this |
|
Not at all a problem ✌️ |
|
can you merge and close this PR |
|
As of now something on the homepage looks messed up |
|
@love-sonkar Any updates? |
fixed #214
i have fixed the responsive issues in cards.
Now cards content is not overflowing.